Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slightly more sane and less repetitive fetching of engines #33

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

Foxinatel
Copy link
Contributor

Mostly just some code cleanup in this PR. The only real change in functionality is that we now fallback to the Kwin tiling engine, as that essentially just mimics standard behavior anyways. We also get to remove the slightly odd level of indirection whereby we push to the engines hashmap using a string in createNewEngine() and then have to use a non-null assertion in the outer function body to get the value back.

@zeroxoneafour
Copy link
Owner

Lgtm, I'm going to go back in later and private some of these methods to prevent TilingEngines from escaping their prison

@zeroxoneafour zeroxoneafour merged commit 7763f45 into zeroxoneafour:master Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants