Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTree: insert new window where active window is #13

Merged
merged 3 commits into from
Jun 7, 2023
Merged

BTree: insert new window where active window is #13

merged 3 commits into from
Jun 7, 2023

Conversation

Daxtorim
Copy link
Contributor

@Daxtorim Daxtorim commented Jun 7, 2023

Added an option for the BTree engine to place new windows where the active window is by splitting that tile in half.

I combined it with the "Invert insertion order" option and converted it to a dropdown menu where you can select "left", "right", and "active window".
Looks like this:
image


PS: I don't know why the diff for the config.ui looks the way it does 😓. I blame QT Designer 😡.

PPS: I would suggest you look into a way to generate the kwinscript with a Github Action when merging/pushing to master and have the artifact published as a nightly release and remove it from git. Right now make clean && make build will generate a different binary every time, making version control a pain.

@zeroxoneafour
Copy link
Owner

Tested the build, works very well! Thank you for this feature.

As for GitHub actions, I'll probably set them up later today now that more pull requests with conflicting build files are coming in.

@zeroxoneafour zeroxoneafour merged commit 15b5098 into zeroxoneafour:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants