Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add windows workflow #3

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove serial tag
  • Loading branch information
zerosnacks committed Apr 29, 2024
commit fb2b2fb74b8b9df744b0db8e5a7eef6f2013b45a
1 change: 0 additions & 1 deletion crates/node-bindings/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,3 @@ url.workspace = true

[dev-dependencies]
rand.workspace = true
serial_test.workspace = true
7 changes: 0 additions & 7 deletions crates/node-bindings/src/geth.rs
Original file line number Diff line number Diff line change
Expand Up @@ -681,18 +681,15 @@ fn extract_endpoint(line: &str) -> Option<SocketAddr> {
#[cfg(test)]
mod tests {
use super::*;
use serial_test::serial;
use std::path::Path;

#[test]
#[serial]
fn test_extract_address() {
let line = "INFO [07-01|13:20:42.774] HTTP server started endpoint=127.0.0.1:8545 auth=false prefix= cors= vhosts=localhost";
assert_eq!(extract_endpoint(line), Some(SocketAddr::from(([127, 0, 0, 1], 8545))));
}

#[test]
#[serial]
fn port_0() {
run_with_tempdir(|_| {
let _geth = Geth::new().disable_discovery().port(0u16).spawn();
Expand All @@ -714,7 +711,6 @@ mod tests {
}

#[test]
#[serial]
fn p2p_port() {
run_with_tempdir(|temp_dir_path| {
let geth = Geth::new().disable_discovery().data_dir(temp_dir_path).spawn();
Expand All @@ -724,7 +720,6 @@ mod tests {
}

#[test]
#[serial]
fn explicit_p2p_port() {
run_with_tempdir(|temp_dir_path| {
// if a p2p port is explicitly set, it should be used
Expand All @@ -735,7 +730,6 @@ mod tests {
}

#[test]
#[serial]
fn dev_mode() {
run_with_tempdir(|temp_dir_path| {
// dev mode should not have a p2p port, and dev should be the default
Expand All @@ -746,7 +740,6 @@ mod tests {
}

#[test]
#[serial]
#[ignore = "fails on geth >=1.14"]
#[allow(deprecated)]
fn clique_correctly_configured() {
Expand Down
1 change: 0 additions & 1 deletion crates/provider/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ alloy-transport-http = { workspace = true, features = ["reqwest"] }

rand.workspace = true
reqwest.workspace = true
serial_test.workspace = true
tokio = { workspace = true, features = ["macros"] }
tracing-subscriber = { workspace = true, features = ["fmt"] }
tempfile.workspace = true
Expand Down
3 changes: 0 additions & 3 deletions crates/provider/src/ext/admin.rs
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,9 @@ mod test {

use super::*;
use alloy_node_bindings::Geth;
use serial_test::serial;
use tempfile::TempDir;

#[tokio::test]
#[serial]
async fn node_info() {
let temp_dir = TempDir::with_prefix("reth-test-").unwrap();
let geth = Geth::new().disable_discovery().data_dir(temp_dir.path()).spawn();
Expand All @@ -88,7 +86,6 @@ mod test {
}

#[tokio::test]
#[serial]
async fn admin_peers() {
let temp_dir = TempDir::with_prefix("reth-test-1").unwrap();
let temp_dir_2 = TempDir::with_prefix("reth-test-2").unwrap();
Expand Down
5 changes: 0 additions & 5 deletions crates/provider/src/ext/txpool.rs
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,8 @@ mod tests {

use super::*;
use alloy_node_bindings::Geth;
use serial_test::serial;

#[tokio::test]
#[serial]
async fn test_txpool_content() {
let temp_dir = tempfile::TempDir::with_prefix("reth-test-").unwrap();
let geth = Geth::new().disable_discovery().data_dir(temp_dir.path()).spawn();
Expand All @@ -86,7 +84,6 @@ mod tests {
}

#[tokio::test]
#[serial]
async fn test_txpool_content_from() {
let temp_dir = tempfile::TempDir::with_prefix("reth-test-").unwrap();
let geth = Geth::new().disable_discovery().data_dir(temp_dir.path()).spawn();
Expand All @@ -96,7 +93,6 @@ mod tests {
}

#[tokio::test]
#[serial]
async fn test_txpool_inspect() {
let temp_dir = tempfile::TempDir::with_prefix("reth-test-").unwrap();
let geth = Geth::new().disable_discovery().data_dir(temp_dir.path()).spawn();
Expand All @@ -106,7 +102,6 @@ mod tests {
}

#[tokio::test]
#[serial]
async fn test_txpool_status() {
let temp_dir = tempfile::TempDir::with_prefix("reth-test-").unwrap();
let geth = Geth::new().disable_discovery().data_dir(temp_dir.path()).spawn();
Expand Down
1 change: 0 additions & 1 deletion crates/rpc-client/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ alloy-transport-ipc = { workspace = true, features = ["mock"] }

tempfile = "3"
futures-util.workspace = true
serial_test.workspace = true

[features]
default = ["reqwest"]
Expand Down
2 changes: 0 additions & 2 deletions crates/rpc-client/tests/it/ipc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ use alloy_primitives::U64;
use alloy_pubsub::PubSubFrontend;
use alloy_rpc_client::{ClientBuilder, RpcCall, RpcClient};
use alloy_transport_ipc::IpcConnect;
use serial_test::serial;
use tempfile::NamedTempFile;

async fn connect() -> (RpcClient<PubSubFrontend>, GethInstance) {
Expand All @@ -24,7 +23,6 @@ async fn connect() -> (RpcClient<PubSubFrontend>, GethInstance) {
}

#[tokio::test]
#[serial]
async fn it_makes_a_request() {
let (client, _geth) = connect().await;
let req: RpcCall<_, (), U64> = client.request("eth_blockNumber", ());
Expand Down
Loading