Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install arm brew on MacOS Arm to install libsodium #542

Merged
merged 8 commits into from
Dec 5, 2022
Merged

Conversation

aminya
Copy link
Member

@aminya aminya commented Dec 4, 2022

@aminya aminya force-pushed the macos-arm branch 3 times, most recently from 4957f4e to 79b67f6 Compare December 4, 2022 21:49
@Bartel-C8
Copy link
Contributor

I did some fixes/changes: Bartel-C8@188cc3a

With the install step, I still get warnings, somewhere the ARCH isn't passed on properly there:

ld: warning: ignoring file /Users/bartel/git/zeromq.js/build/libzmq/lib/libzmq.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
ld: warning: ignoring file /Users/bartel/arm-target/Cellar/libsodium/1.0.18_1/lib/libsodium.dylib, building for macOS-x86_64 but attempting to link with file built for macOS-arm64

Prebuild is okay now (untested binary, I don't have an ARM machine):

  SOLINK_MODULE(target) Release/zeromq.node
rm 7722eaf02fcc073df28ffd1fa831e71544edfd42.intermediate
gyp info ok 

@Bartel-C8
Copy link
Contributor

Bartel-C8 commented Dec 5, 2022

Fixed pnpm install as well: Bartel-C8@af8f5c4

On re-install (run ARCH=arm64 pnpm install again) you get a warning:

dlopen(/Users/bartel/git/zeromq.js/build/Release/zeromq.node, 0x0001): tried: '/Users/bartel/git/zeromq.js/build/Release/zeromq.node' (mach-o file, but is an incompatible architecture (have 'arm64', need 'x86_64h' or 'x86_64')), 
'/System/Volumes/Preboot/Cryptexes/OS/Users/bartel/git/zeromq.js/build/Release/zeromq.node' (no such file), '/Users/bartel/git/zeromq.js/build/Release/zeromq.node' (mach-o file, but is an incompatible architecture (have 'arm64', need 'x86_64h' or 'x86_64'))

But that's because of the dlopen is the one of nodejs, which is in my case a x86_64 built.

@aminya
Copy link
Member Author

aminya commented Dec 5, 2022

Thanks for the changes. I have merged your suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants