updates for php7.4 and php8.0 #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code is autogenerated by the *.gsl scripts. In order to minimize the c code now parts of the gsl code generation is moved to new makro definitions in zmq_sockopts_makros.h This reduces the overall lines of the file and makes it more readable for future additions of flags.
- fixed unstable tests - add pthreads for php7.2
- travisci enabled php7.4 and php8.0 - removed now unused references to TSRMLS_* These flags were mostly already removed from the php7 codebase but some instances were still present. With php8 these produce compile errors. - fix tests for php8 and php7.4 New TypeErrors now get handled correctly in the test cases. - fix memory corruption in zmq.c The conflicting line causes memory leaks on other php version and causes a segfault on php8 and php7.4 The error was provocable with test case 021-callbackwarning.phpt. After removing of the line valgrind showed no memory leak, so this line was probably redundant. Also if you compare with zmqsocket constructor this line is also not present.
|
Please do a rebase instead of a recusrive merge. Something like: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These flags were mostly already removed from the
php7 codebase but some instances were still present.
With php8 these produce compile errors.
New TypeErrors now get handled correctly in the test cases.
The conflicting line causes memory leaks on other php
version and causes a segfault on php8 and php7.4
The error was provocable with test case
021-callbackwarning.phpt. After removing of the line
valgrind showed no memory leak, so this line was probably
redundant. Also if you compare with zmqsocket constructor
this line is also not present.