Adopt CMake minimum version number #4789
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake 4.0 deprecated old versions, which breaks all CIs that update CMake. There is no technical value to stick to an outdated unsupported CMake version, This PR sets the minimum version to a reasonable range. Fix zeromq#4786
|
None of the CI checks have to do with the change, but are related to other things (like changes in the test runners) |
|
Just found out this looks like a duplicate of #4776 , but anyhow, whatever fixes the problem, it should already be in main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: CMake build is broken with recent CMake versions (4 and above)
Solution: Set CMake version to a reasonable minimum
Fix #4786
Additional information: This PR sets the CMake version to a min/max range so CMake can determine the best behaviour for the existing CMake version.
This will still allow CMake 3.0 to work, while not breaking for CMake 4.0,
CMake 3.0 is 10+ year old, so zmq will still support older systems