using '_M_ARM' macros for Windows ARM comilation #4051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 5, 2020 11:47
[why] In order to compile ZMQ related software on WINDOWS ARM [how] Replaced code in the file clock.cpp around the line 240. Added intrinsics for ARM to replace '__rdtsc' [todo] Find proper tick counter query for ARM64 (see file:clock.cpp,line:~250)
[why] To make usage of changed code properly usable by libzmq project team [how] Added file /RELICENSE/kalantar.md with necessary information
[why] For CI [how] Replaced tab by 4 spaces
[why] 1. In order to be synchrone 2. To make some minor change in header to take macros '_M_ARM' for the windows arm
[why] This is a standard microsoft compiler macros https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=vs-2019 This macros is defined for example for Windows 10 core Iot (for example paspberry pi windows compilation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Windows ARM 32 bit compilations microsoft compiler uses
_M_ARMpredefined macros (https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=vs-2019).Added this macros in the checking of platform in the defination of structure
zmq_msg_t(please check zmq.h line~255)