Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using '_M_ARM' macros for Windows ARM comilation #4051

Merged
merged 5 commits into from
Sep 26, 2020

Conversation

davitkalantaryan
Copy link
Contributor

For Windows ARM 32 bit compilations microsoft compiler uses _M_ARM predefined macros (https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=vs-2019).
Added this macros in the checking of platform in the defination of structure zmq_msg_t (please check zmq.h line~255)

Davit Kalantaryan added 5 commits August 5, 2020 11:47
[why]
In order to compile ZMQ related software on WINDOWS ARM

[how]
Replaced code in the file clock.cpp around the line 240.
Added intrinsics for ARM to replace '__rdtsc'

[todo]
Find proper tick counter query for ARM64 (see file:clock.cpp,line:~250)
[why]
To make usage of changed code properly usable by libzmq project team

[how]
Added file /RELICENSE/kalantar.md with necessary information
[why]
For CI

[how]
Replaced tab by 4 spaces
[why]
 1. In order to be synchrone
 2. To make some minor change in header to take macros '_M_ARM' for the windows arm
[why]
This is a standard microsoft compiler macros https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=vs-2019
This macros is defined for example for Windows 10 core Iot (for example paspberry pi windows compilation)
@bluca bluca merged commit dfc85af into zeromq:master Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants