Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::condition_variable_any, move configuration to build files #3405

Merged
merged 6 commits into from
Feb 12, 2019

Commits on Feb 11, 2019

  1. Problem: std::condition_variable can only be used with std::unique_lo…

    …ck<std::mutex>, leading to two mutexes used in condition_variable_t
    
    Solution: use std::condition_variable_any instead
    sigiesec committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    d7e1cf3 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2019

  1. Problem: value for _WIN32_WINNT not always known in CMakeLists.txt

    Solution: calculate from CMAKE_SYSTEM_VERSION
    
    Problem: CMAKE_SYSTEM_VERSION might be newer than Windows SDK Version
    
    Solution: limit _WIN32_WINNT value to Visual Studio default Windows SDK version
    sigiesec committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    bfb092c View commit details
    Browse the repository at this point in the history
  2. Problem: selection of condition_variable_t implementation is confusin…

    …g and not configurable
    
    Solution: move configuration to build definition
    sigiesec committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    120edd9 View commit details
    Browse the repository at this point in the history
  3. Problem: test_security_curve build fails with Windows targeting 8 or …

    …newer due to duplicate definition of htonll
    
    Solution: use custom implementation only on older Windows versions
    sigiesec committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    21a389c View commit details
    Browse the repository at this point in the history
  4. Problem: C4267 warnings due to implicit conversion from size_t to int

    Solution: change variable type to size_t
    sigiesec committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    2759f45 View commit details
    Browse the repository at this point in the history
  5. Problem: assertion triggered in stream_connecter_base::close

    Solution: change into regular control flow condition
    sigiesec committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    7fbd977 View commit details
    Browse the repository at this point in the history