Problem: missing flags break build of test_security_curve #2688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: add all the required compiler flags since the test includes source code from the library directly
jimklimov
reviewed
Aug 17, 2017
| @@ -638,9 +638,13 @@ tests_test_security_curve_SOURCES += \ | |||
| endif | |||
|
|
|||
| tests_test_security_curve_LDADD = \ | |||
| src/libzmq.la | |||
| src/libzmq.la $(LIBUNWIND_LIBS) | |||
There was a problem hiding this comment.
Sanity check : Wasn't libunwind an optional dependency (or am I mistaking projects)? Should this either become required dependency for this test to get built, or #if HAVE_LIBUNWIND trickery is needed?
There was a problem hiding this comment.
The variable will be empty if it's not found or disabled
There was a problem hiding this comment.
And will compilation break if the library is missing, then?
There was a problem hiding this comment.
It's ifdef'd in err.hpp - which is included by the test, so it was breaking when the library was there because the test was not being linked against it, despite the ifdef being true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: add all the required compiler flags since the test includes
source code from the library directly