Skip to content

tests/CMakeLists.txt uses target_sources but says it works with CMake 2.8.1 #2728

Closed
@fove-robin

Description

@fove-robin

Please use this template for reporting suspected bugs or requests for help.

Issue description

tests/CMakeLists.txt uses CMake's target_sources, which was only added in CMake 3.1.
cmake_minimum_required is set to 2.8.1 in that file, and 2.8.12 in the project root.

This is causing libzmq project's Jenkins to fail:
https://libzmq.cloudapp.net/job/libzmq/1820/console

Note Jenkins isn't reporting the problem, but it's not exactly working either...

Environment

  • libzmq version (commit hash if unreleased): d5e4319
  • OS: all
  • CMake: before v3.1

Minimal test code / Steps to reproduce the issue

  1. kick off CI on Jenkins

What's the actual result? (include assertion message & call stack if applicable)

CMake Error at tests/CMakeLists.txt:184 (target_sources):
  Unknown CMake command "target_sources".

What's the expected result?

Jenkins should build, not just flake out and say "SUCCESS!" (Fixing Jenkins itself is a separate issue I guess...?)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions