Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZMQ_HAVE_POLLER and ZMQ_BUILD_DRAFT_API #2540

Closed
juan-filewave opened this issue Apr 20, 2017 · 2 comments
Closed

ZMQ_HAVE_POLLER and ZMQ_BUILD_DRAFT_API #2540

juan-filewave opened this issue Apr 20, 2017 · 2 comments

Comments

@juan-filewave
Copy link
Contributor

In zmq.h ZMQ_HAVE_POLLER is defined iff ZMQ_BUILD_DRAFT_API is defined. But in zmq_draft.h ZMQ_HAVE_POLLER is defined following the inverse logic, ie, iff ZMQ_BUILD_DRAFT_API is not defined.
For my usage in Windows, I'm interested into not having ZMQ_HAVE_POLLER defined and use poll (WSAPoll in windows.hpp), but I can't unless I modify the code, and I'm not sure to understand if ZMQ_HAVE_POLLER should be defined iff ZMQ_BUILD_DRAFT_API is defined, of the other way around.

@bluca
Copy link
Member

bluca commented Apr 20, 2017

poll will be used, but through the new zmq_poller code

@bluca
Copy link
Member

bluca commented Apr 28, 2017

I have now realised what you mean, and it's absolutely true the new poller is used whether the users wants it or not - will send a PR to fix it shortly as it should be optional until it's finalised

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants