program dumps core when getpeername() returns EINVAL

[jkryl]

I was running an application using libzmq on solaris and it was dumping core when starting. I traced the problem to zmq::get_peer_ip_address() in ip.cpp, where getpeername() libc function fails with errno set to EINVAL. libzmq considers EINVAL to be consequence of a bug in its implementation thus it dumps core. However open group specification explicitly mentions EINVAL among valid errno codes for getpeername and it should be generated when the peer has closed the connection (http://pubs.opengroup.org/onlinepubs/009695399/functions/getpeername.html).

It seems to me that libzmq should be fixed and EINVAL should be taken out from the assert in get_peer_ip_address.

[hintjens]

Sounds good... will you make a pull request with that patch?

On Tue, Jun 10, 2014 at 12:13 AM, Jan Kryl notifications@github.com wrote:

I was running an application using libzmq on solaris and it was dumping
core when starting. I traced the problem to zmq::get_peer_ip_address() in
ip.cpp, where getpeername() libc function fails with errno set to EINVAL.
libzmq considers EINVAL to be consequence of a bug in its implementation
thus it dumps core. However open group specification explicitly mentions
EINVAL among valid errno codes for getpeername and it should be generated
when the peer has closed the connection (
http://pubs.opengroup.org/onlinepubs/009695399/functions/getpeername.html
).

It seems to me that libzmq should be fixed and EINVAL should be taken out
from the assert in get_peer_ip_address.

—
Reply to this email directly or view it on GitHub
#1085.

[jkryl]

thanks for looking at this. I will submit a pull request.

[nljmo]

@hintjens Does this satisfy you? if so could it be merged?

[rodgert]

That change already appears to be in libzmq

[xaqq]

Indeed this change has been merged and the current code doesn't assert on EINVAL.
Closing this issue.