Based on #4462, it has been improved and is compatible with previous versions #4775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…kage and package parameters are added
kevwan
requested review from
kesonan and
Copilot
and removed request for
kesonan
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for custom package names in MongoDB model generation, making it backward compatible with previous versions. The main purpose is to allow users to specify package names other than the hardcoded "model" package.
- Added two new command-line flags:
--auto-packageand--packagefor controlling package naming - Updated all template files to use a configurable
{{.PackageName}}placeholder instead of hardcoded "model" - Enhanced the generation logic to determine package names based on user preferences or directory names
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/goctl/model/mongo/template/*.tpl | Updated package declarations to use configurable PackageName template variable |
| tools/goctl/model/mongo/mongo.go | Added package name determination logic and new command-line variables |
| tools/goctl/model/mongo/generate/generate.go | Enhanced Context struct and template data to include PackageName |
| tools/goctl/model/cmd.go | Added new command-line flag bindings for package configuration |
| tools/goctl/internal/flags/default_en.json | Added flag descriptions for new package-related options |
| tools/goctl/model/mongo/readme.md | Updated documentation with new flags and examples |
| "easy": "Generate code with auto generated CollectionName for easy declare [optional]", | ||
| "dir": "{{.goctl.model.dir}}", | ||
| "auto-package": "Whether to automatically use the name of the directory where the build file is located as the package name [optional,default=false]\nIt is mainly used to be compatible with previous versions,If this parameter is set to false, the package name is set to model by default", | ||
| "package": "Manually specify the package name, which takes precedence over VarBoolPkgAuto [optional]", |
There was a problem hiding this comment.
The documentation refers to 'VarBoolPkgAuto' but the actual variable name is 'VarBoolAutoPackage'. This inconsistency could confuse users.
Suggested change
| "package": "Manually specify the package name, which takes precedence over VarBoolPkgAuto [optional]", | |
| "package": "Manually specify the package name, which takes precedence over VarBoolAutoPackage [optional]", |
Copilot uses AI. Check for mistakes.
| // - Whether to automatically use the name of the directory where the build file is located as the package name | ||
| // - It is mainly used to be compatible with previous versions,If this parameter is set to false, the package name is set to model by default | ||
| VarBoolAutoPackage bool | ||
| //VarStringPackage Manually specify the package name, which takes precedence over VarBoolPkgAuto |
There was a problem hiding this comment.
The comment refers to 'VarBoolPkgAuto' but the actual variable name is 'VarBoolAutoPackage'. This should be updated for consistency.
Suggested change
| //VarStringPackage Manually specify the package name, which takes precedence over VarBoolPkgAuto | |
| //VarStringPackage Manually specify the package name, which takes precedence over VarBoolAutoPackage |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
基于 #4462 进行了后续完善，兼容了历史版本
支持 mongo 的自定义model package name