feat/sqlx_metric

[MarkJoyMa]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 94.55%. Comparing base (8690859) to head (b974c36).
Report is 223 commits behind head on master.

Files with missing lines	Patch %	Lines
core/stores/sqlx/sqlmanager.go	0.00%	11 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
core/stores/sqlx/sqlmanager.go	50.00% <0.00%> (-17.75%)	⬇️

... and 8 files with indirect coverage changes

[kevwan]

Review Comments:

1. Error Handling:

   • The error from mysql.ParseDSN is silently ignored with a comment "do nothing here"
   • Consider logging the error or handling it more explicitly

2. Security Consideration:

   • Good practice using SHA-256 for hashing the server string to avoid exposing sensitive connection details in metrics

3. Code Style:

   • The code follows the project's style guidelines
   • The changes are well-structured and easy to understand

4. Potential Improvements:

   • Consider adding documentation for the new metrics collection feature
   • Could add comments explaining the purpose of the hash and why it's needed
   • The error handling for ParseDSN could be more explicit

The PR appears to be a useful addition that adds metrics collection capabilities for MySQL connections, which would help in monitoring and debugging database connection pools. However, I would recommend:

1. Adding documentation about the new metrics collection feature
2. Improving the error handling for the DSN parsing
3. Adding tests for the new functionality