Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/redis_hook #4233

Merged
merged 8 commits into from
Jul 7, 2024
Merged

feat/redis_hook #4233

merged 8 commits into from
Jul 7, 2024

Conversation

MarkJoyMa
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.10%. Comparing base (8690859) to head (4495981).
Report is 78 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
core/stores/redis/redis.go 99.82% <100.00%> (+0.04%) ⬆️

... and 254 files with indirect coverage changes

@kevwan kevwan force-pushed the feat/redis_hook branch from 5b0c2e0 to 37e3c81 Compare July 7, 2024 02:52
@kevwan
Copy link
Contributor

kevwan commented Jul 7, 2024

There is a problem is that if we make this change, then go-redis is explicitly depended. For example, when we upgraded v8 to v9, no change required for the client code.

@kevwan kevwan force-pushed the feat/redis_hook branch from 28c3294 to 4495981 Compare July 7, 2024 04:33
@kevwan kevwan added this pull request to the merge queue Jul 7, 2024
Merged via the queue into zeromicro:master with commit fed835b Jul 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants