Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace NewBetchInserter function name #2769

Merged
merged 3 commits into from
Jan 9, 2023
Merged

feat: replace NewBetchInserter function name #2769

merged 3 commits into from
Jan 9, 2023

Conversation

MarkJoyMa
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2023 •
edited
Loading

Codecov Report

Merging #2769 (59a28e6) into master (0c786ca) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
core/stores/mon/bulkinserter.go 72.09% <100.00%> (-2.38%) ⬇️
core/logx/rotatelogger.go 72.69% <0.00%> (-1.11%) ⬇️

kevwan
kevwan approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@kevwan kevwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kevwan kevwan merged commit 0defb75 into zeromicro:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan kevwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkJoyMa @codecov-commenter @kevwan