Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add middlewares config for rest #2765

Merged
merged 3 commits into from
Jan 8, 2023
Merged

feat: add middlewares config for rest #2765

merged 3 commits into from
Jan 8, 2023

Conversation

kevwan
Copy link
Contributor

@kevwan kevwan commented Jan 8, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2023 •
edited by codecov bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.94%. Comparing base (f450217) to head (bab0170).
Report is 841 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
rest/engine.go 92.92% <100.00%> (+0.94%) ⬆️
rest/handler/maxconnshandler.go 85.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

zhoushuguang
zhoushuguang approved these changes Jan 8, 2023
View reviewed changes
Copy link
Collaborator

@zhoushuguang zhoushuguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

chenquan
chenquan approved these changes Jan 8, 2023
View reviewed changes
Copy link
Member

@chenquan chenquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevwan kevwan merged commit ade6f9e into zeromicro:master Jan 8, 2023
@kevwan kevwan deleted the feat/rest-middlewares branch January 8, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhoushuguang zhoushuguang zhoushuguang approved these changes

@chenquan chenquan chenquan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevwan @codecov-commenter @zhoushuguang @chenquan