Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mysql and redis metric support #2355

Merged
merged 3 commits into from
Sep 17, 2022
Merged

feat: mysql and redis metric support #2355

merged 3 commits into from
Sep 17, 2022

Conversation

zhoushuguang
Copy link
Collaborator

No description provided.

chenquan
chenquan reviewed Sep 5, 2022
View reviewed changes
core/stores/sqlx/metrics.go
"github.com/zeromicro/go-zero/core/prometheus"
)

const namespace = "mysql_client"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better this way: mysql -> sql

@kevwan kevwan merged commit ae7f1aa into zeromicro:master Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenquan chenquan chenquan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhoushuguang @chenquan @kevwan