Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rpc add health check function configuration optional #2288

Merged
merged 2 commits into from
Aug 23, 2022
Merged

feat: rpc add health check function configuration optional #2288

merged 2 commits into from
Aug 23, 2022

Conversation

MarkJoyMa
Copy link
Collaborator

@MarkJoyMa MarkJoyMa commented Aug 23, 2022 •
edited
Loading

fix #2278

kevwan
kevwan approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@kevwan kevwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevwan kevwan merged commit 040c9e0 into zeromicro:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan kevwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate service registration for "grpc.health.v1.Health" when upgrading go-zero from 1.3.1 to 1.4.0
2 participants
@MarkJoyMa @kevwan