Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: put grpc reflection into server.go #2058

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevwan
Copy link
Contributor

@kevwan kevwan commented Jun 28, 2022

No description provided.

@kevwan kevwan added the do-not-merge/hold Indicates that a PR should not merge because of known issues or need more discussion. label Jul 23, 2022
@kevwan
Copy link
Contributor Author

kevwan commented Jul 23, 2022

Because of compatibility problem, don't merge at this moment.

This PR might cause reflection.Register the same service twice, if users use the old goctl versions and new go-zero versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because of known issues or need more discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant