Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rpc dial can be set with NonBlock mode #1198

Merged
merged 1 commit into from
Nov 2, 2021
Merged

feat: rpc dial can be set with NonBlock mode #1198

merged 1 commit into from
Nov 2, 2021

Conversation

kevwan
Copy link
Contributor

@kevwan kevwan commented Nov 2, 2021 •
edited
Loading

  1. use WithBlock() by default
  2. NonBlock can be set in config or WithNonBlock() option

@kevwan kevwan changed the title feat: use WithBlock() by default, NonBlock can be set in config or Wi… feat: rpc dial can be set with NonBlock mode Nov 2, 2021
@kevwan kevwan added the feature Marks an issue or PR as related to a new feature. label Nov 2, 2021
@kevwan kevwan added this to the 1.2.3 milestone Nov 2, 2021
@kevwan kevwan requested a review from zhoushuguang November 2, 2021 10:52
zhoushuguang
zhoushuguang reviewed Nov 2, 2021
View reviewed changes
Copy link
Collaborator

@zhoushuguang zhoushuguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+lgtm

@kevwan kevwan merged commit 1ece3a4 into zeromicro:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhoushuguang zhoushuguang zhoushuguang left review comments

Assignees
No one assigned
Labels
feature Marks an issue or PR as related to a new feature.
Projects
None yet
Milestone
1.2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@kevwan @zhoushuguang