Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ambigous user_id in json parsing #77

Merged
merged 1 commit into from
Mar 21, 2022
Merged

fix: ambigous user_id in json parsing #77

merged 1 commit into from
Mar 21, 2022

Conversation

rhnvrm
Copy link
Member

@rhnvrm rhnvrm commented Mar 9, 2022

As reported by @vishnus, user_id was not being parsed correctly from the responses in UserSession struct as it contained two user_id embeds.

This commit fixes the same.

@rhnvrm rhnvrm requested a review from vividvilla March 9, 2022 13:59
@ranjanrak
Copy link
Member

Looks good to me. Can we also add, profile.UserID check in GetUserProfile unit test?

@rhnvrm rhnvrm merged commit fdbe590 into zerodha:master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vividvilla vividvilla Awaiting requested review from vividvilla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhnvrm @ranjanrak