Update doc-comments in Current, ObjectAdapter, ServantLocator #3793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
Mar 27, 2025
pepone
approved these changes
Mar 28, 2025
| /// ObjectNotExistException or a FacetNotExistException. | ||
| /// @param servant The default servant to add. | ||
| /// @param category The category for which the default servant is registered. The empty category means it | ||
| /// handles all categories. |
There was a problem hiding this comment.
What about mentioning collocated transport would not consider default servants when checking if an object is local.
There was a problem hiding this comment.
It's actually more complicated and hard to explain succinctly.
See
ice/cpp/src/Ice/ObjectAdapterI.cpp
Line 650 in 80c9e6b
externl
approved these changes
Mar 28, 2025
cpp/include/Ice/ObjectAdapter.h
Outdated
| /// @see #activate | ||
| /// @see #deactivate | ||
| /// @see #waitForHold | ||
| /// Temporarily holds receiving and dispatching requests. The object adapter can be reactivated with #activate. |
There was a problem hiding this comment.
hold and waitForHold need new doc comments :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.