Add mask in History

[mpmo10]

Is your feature request related to a problem? Please describe.
Problem is when I do ctrl + z to bring back the mask, it doesn't bring it back. Only brings back the previous generation (or the original pic)

Describe the solution you'd like
When doing ctrl + z after a generation that I clicked "Y" to, I want the previous generation come back while the mask that I've put stays in its place and doesn't go away. So basically can you please add the option of putting the mask history in "History" tab?

[zero01101]

so if i recall correctly, there's some quibbles with adding mask actions to history - @seijihariki might need to correct me because there's a high likelihood i'm wrong lol - but as an alternative to that, if you git checkout clear_brush_mask_option there should now be an option to preserve brushed masks in the dream and img2img tool context menus, which applies after accepting an image if you'd care to see if that does something like you're desiring

[seijihariki]

There are no actual implementation barriers regarding this, it was mostly a "we ended up doing this way, so it stayed" kind of thing. It was even a possibility I gave when discussing the implementation of the color brush tool: #64 (comment)

Implementation of this feature would be basically the same as the current implementation of color brushes. I think we should start finding some ways to organize the history because long editing sessions will have hundreds of entries there, many of them the same (50 entries of "Mask Brush Draw" and "Mask Brush Erase" one after another)...

Maybe even some "history cleaning", such as keeping the most recent n entries in the history (n defined on the settings page, probably). This should also allow freeing the RAM during long editing sessions and deleting unused layers. (we could also store history entries in the indexedDB. (workspaces and saving sessions, maybe??)

[zero01101]

It was even a possibility I gave when discussing the implementation of the color brush tool:

yknow i literally missed that entire sentence in that post until now?? i promise i can read :|

i definitely think a history max x entries setting is a good idea just in general as well for what it's worth

[mpmo10]

so if i recall correctly, there's some quibbles with adding mask actions to history - @seijihariki might need to correct me because there's a high likelihood i'm wrong lol - but as an alternative to that, if you git checkout clear_brush_mask_option there should now be an option to preserve brushed masks in the dream and img2img tool context menus, which applies after accepting an image if you'd care to see if that does something like you're desiring

oh ok will try that tonight thanks! Also, is there a way to increase the max steps count from 70 to 200? Sometimes for bigger outpainting jobs 70 isn't enough imo. So is there anyway I can edit one of the files to change the max 70 number..?

[seijihariki]

I feel some slider ranges should be configurable in the settings menu... For now, editing js/index.js should not be hard to increase the range. It has a bunch of 'createSlider' functions, and you just need to change the max value passed to it.

[seijihariki]

So you don't have to manually search for the correct slider, it is here:

openOutpaint/js/index.js

Line 606 in 35d5868

makeSlider("Steps", document.getElementById("steps"), "steps", 1, 70, 5, 30, 1);

Just change 70 to whatever you need for now, but I will give a look to making these more easily configurable.

[mpmo10]

So you don't have to manually search for the correct slider, it is here:

openOutpaint/js/index.js

Line 606 in 35d5868

makeSlider("Steps", document.getElementById("steps"), "steps", 1, 70, 5, 30, 1);

Just change 70 to whatever you need for now, but I will give a look to making these more easily configurable.

nice thanks!

[mpmo10]

I did "git pull" but the mask goes away even after I choose "Y" to a generation and then undo. Am I doing something wrong?

[zero01101]

did you run git checkout clear_brush_mask_option before git pull? there should be a new option checkbox in the context menu

[mpmo10]

I got this error:

"(base) Z:\openOutpaint\openOutpaint>git checkout clear_brush_mask_option
error: Your local changes to the following files would be overwritten by checkout:
js/index.js
Please commit your changes or stash them before you switch branches.
Aborting"

I did edit the index.js to increase 70 steps to 200. Is that what's causing the issue?

[zero01101]

yep, that'd be it - you can run git stash to put index.js back to unmodified state, and you should be able to checkout the other branch

[mpmo10]

yep, that'd be it - you can run git stash to put index.js back to unmodified state, and you should be able to checkout the other branch

Hmm it says it worked but I still don't see the option in the context menu