Added something to animation-nation repository #2982
Conversation
|
🙏 Thanks for your pull request @DRGGamble, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @DRGGamble, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
There was a problem hiding this comment.
Aloha @DRGGamble 🙌
Thanks for your contributions :)
Here are few feedbacks you could address.
Also - the meta.json file is missing.
Feel free to review the README.md to check how to contribute and understand what is missing and what should not be added in the contribution. These are mentioned in the feedback I gave you which should guide you.
Happy coding
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>Something</title> | ||
| <link rel="stylesheet" type="text/css" href="style.css"> |
There was a problem hiding this comment.
Incorrect css file name to use
The file should not be style.css -> Please checks the readme there is currently a typo.
This is why this line will need to be corrected along as the file name
There was a problem hiding this comment.
No extra file
- Please remove this file: you should only have one
index.htmland onestyles.cssandmeta.jsonfiles
There was a problem hiding this comment.
No modifications allowed on public/cards.json
This file updates on its own - To add the json part, you need to provide a meta.json
- Please remove any changes on this file
|
🙏 Thanks for your pull request @DRGGamble, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
1 similar comment
|
🙏 Thanks for your pull request @DRGGamble, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @DRGGamble, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
1 similar comment
|
🙏 Thanks for your pull request @DRGGamble, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
Aloha @DRGGamble , Above are few feedbacks to address before it could be merge if you want :) |
|
🙏 Thanks for your pull request @DRGGamble, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
Please review and approve my first contribution to animation-nation at the earliest convenience