Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Paymaster Transactions on Ledger #660

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Support Paymaster Transactions on Ledger #660

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be22b7e
Support Paymaster Transactions on Ledger
everdimension Nov 14, 2024
2f88915
remove comment
everdimension Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove comment
  • Loading branch information
@everdimension
everdimension committed Nov 15, 2024
commit 2f889156a04972c4b972aa2dc8424f3398ff0844
3 changes: 0 additions & 3 deletions src/ui/pages/HardwareWalletConnection/HardwareSignTransaction/HardwareSignTransaction.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,6 @@ export const HardwareSignTransaction = React.forwardRef(
'Iframe contentWindow is not available'
);
try {
// NOTE: Conditionally handle Paymaster Tx here? Query TypedData to sign from Wallet.ts,
// sign it via { id, method: 'signTypedData_v4' }, then? decide? maybe do a wallet request
// to zkSyncUtils.serialize() it, then return the result?... it'll proceed to Wallet
const result = await signRegularOrPaymasterTx({
transaction: normalizedTransaction,
messageHandler: hardwareMessageHandler,
Expand Down
Loading