Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix type issues occured after npm audit fix #206

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

melsener
Copy link
Member

@melsener melsener commented Nov 11, 2024

Change description

Fix type issues occured after npm audit fix. Errors listed below:

○  (Static)  automatically rendered as static HTML (uses no initial props)

src/server/adapters/logger/errorTracker.ts:67:46 - error TS2345: Argument of type 'object' is not assignable to parameter of type 'Context | null'.
  Type 'object' is not assignable to type 'Context'.
    Index signature for type 'string' is missing in type '{}'.

67                     scope.setContext("Meta", meta);
                                                ~~~~

src/server/adapters/logger/errorTracker.ts:71:49 - error TS2345: Argument of type 'LoggerContext' is not assignable to parameter of type 'Context'.
  Index signature for type 'string' is missing in type 'LoggerContext'.

71                     scope.setContext("Context", context);
                                                   ~~~~~~~


Found 2 errors.

See the Github action result here: https://github.com/zeplin/microsoft-teams-app/actions/runs/11780335273

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and it follows conventional commit format and breaking change indicator if required (You can use the Angular convention)
  • Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@melsener melsener merged commit b26d993 into main Nov 12, 2024
1 check passed
@melsener melsener deleted the fix/fix-type-issues-of-npm-audit branch November 12, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants