drivers: udc: usb: stm32: clock configuration cleanup #99825
+31
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sumed Instead of using global macro "USB_RAM_SIZE", replace it by its content (i.e., DT_INST_PROP()) in the only place where it was used. Signed-off-by: Mathieu Choplain <mathieu.choplain-ext@st.com>
To enable/disable clocks, the UDC driver used function pointers stored in the instance private data(!), which *could* be NULL... but in practice, they were always initialized. Furthermore, the clock configuration is done through Clock Control API calls so the code can be shared by all instances. Replace indirect calls through function pointers with direct calls to the "priv_clock_(dis|en)able" function, which are renamed to "udc_stm32_..." for consistency with the rest of the driver. The now-unused function pointers are also removed from the instance data structure. Signed-off-by: Mathieu Choplain <mathieu.choplain-ext@st.com>
Instead of using globals, save the clock configuration from DTS in each instance's configuration block, from which it is consumed by the driver's clock configuration functions. Signed-off-by: Mathieu Choplain <mathieu.choplain-ext@st.com>
mathieuchopstm
added
area: USB
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
jfischer-no,
josuah,
juickar and
tmon-nordic
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up how clocks are configured/enabled in the driver with multi-instance in mind. Another larger rework will be required for PHYs but this is W.I.P. and will come in a later PR.
While at it, fix a "bug" where driver attempts to obtain rates from non-existent clocks, and get rid of the
USB_RAM_SIZEmacro that is near refactored code and serves no purpose.