Bluetooth: ISO: Move iso dereference after assertion #99020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth ISO
zephyrbot
requested review from
Thalley,
cvinayak,
jhedberg and
rugeGerritsen
Thalley
previously approved these changes
Nov 6, 2025
Contributor
Thalley
left a comment
Thalley
left a comment
There was a problem hiding this comment.
Change is fine with one minor suggestion
1 task
Make sure assertion is true before dereferencing chan->iso. In extreme case compiler could skip assert check (asume it is always false) if address was already dereferenced. Signed-off-by: Szymon Janc <szymon.janc@codecoup.pl>
sjanc
force-pushed
the
host_iso_assert
branch
from
49750dd to
afa6bc2
Compare
|
Thalley
approved these changes
Nov 6, 2025
jhedberg
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure assertion is true before dereferencing chan->iso. In extreme case compiler could skip assert check (asume it is always false) if address was already dereferenced.