-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: net: Run networking tests only for selected platforms #9679
Conversation
We could even lower the number of tests if we skip testing in qemu_x86, that would lower the test count from 147 to 103 for tests/net directory. If this would be ok, I can send a new version that does that. |
Added fixed bugs list in commit message. |
Codecov Report
@@ Coverage Diff @@
## master #9679 +/- ##
==========================================
- Coverage 52.31% 52.12% -0.19%
==========================================
Files 212 212
Lines 25939 25939
Branches 5590 5590
==========================================
- Hits 13569 13521 -48
- Misses 10123 10177 +54
+ Partials 2247 2241 -6
Continue to review full report at Codecov.
|
I think that would go too far. |
Trying this patch together with #7831 (in the hope that it'll be possible to merge it afterwards!), and it uncovers some missed samples: samples/net/telnet, samples/net/dhcpv4_client, samples/net/dns_resolve, samples/net/nats, samples/net/syslog_net |
This PR only checks things under tests/net directory which was the whole point of this PR. It probably does not make sense to try to prevent sanitychecker from using samples/net programs. |
So, I don't see any good points in this PR - it decreases build coverage, which is generally bad, but could work as a stopgap measure to address #9015 until better solution comes up. But it stops short of fully masking #9015 and being able to resolve #7831. |
This PR does not decrease build coverage, it merely prevents unnecessary builds for tests/net directory. Those unit tests can safely be run in couple of architectures only. |
What about network driver code coverage from platforms which get excluded? Anyway, I guess the best thing for me is to approve this, even if this doesn't clear the way for #7831, it goes in the needed direction (even if needed direction is a stopgap measure, again). (Otherwise, I thought someone else approves it anyway, surprised nobody did yet.) |
Run networking tests for native_posix, qemu_x86 and qemu_cortex_m3 platforms only as the tests are generic enough so no need to run them in real physical device. Fixes zephyrproject-rtos#9623 zephyrproject-rtos#9614 zephyrproject-rtos#9622 zephyrproject-rtos#9621 zephyrproject-rtos#9618 Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
No need to have setup and teardown functions. Teardown will even cause crash when tearing down last IPv4 test. Fixes zephyrproject-rtos#9617 Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
well, tbh I do not like the approach here, we need to do this better, but right now this is the only way I can see it done. I will try to streamline how this will be done in sanitycheck in testing in general after 1.13. |
Run networking tests for native_posix, qemu_x86 and qemu_cortex_m3
platforms only as the tests are generic enough so no need to run
them in real physical device.
Signed-off-by: Jukka Rissanen jukka.rissanen@linux.intel.com