Skip to content

Conversation

alwa-nordic
Copy link
Contributor

I believe there is some confusion about what this function does. This function is doing some type-bending, so it's extra important to document it.

I believe there is some confusion about what this function does. This
function is doing some type-bending, so it's extra important to document
it.

Signed-off-by: Aleksander Wasaznik <aleksander.wasaznik@nordicsemi.no>
@alwa-nordic alwa-nordic force-pushed the doc/bt_addr_le_is_resolved branch from 07ab634 to ad31156 Compare August 26, 2025 11:43
@PavelVPV
Copy link
Contributor

Would it be better to define an bt_hci_addr_le_t (or something) which can be just a redefine of bt_addr_le_t (this is not so important) and use type in those events as well as a type for an argument of this function?

Copy link

@Thalley Thalley requested a review from Copilot August 26, 2025 12:53
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive documentation to the bt_addr_le_is_resolved() function to clarify its purpose and usage constraints. The function performs type inspection on HCI LE event address fields to determine if the Controller resolved a Resolvable Private Address (RPA).

Key Changes

  • Added detailed documentation explaining the function's specific purpose for HCI LE event address inspection
  • Clarified the critical distinction between HCI event address fields and regular application-layer bt_addr_le_t types
  • Provided comprehensive list of HCI LE events that contain compatible address fields

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@PavelVPV
Copy link
Contributor

Would it be better to define an bt_hci_addr_le_t (or something) which can be just a redefine of bt_addr_le_t (this is not so important) and use type in those events as well as a type for an argument of this function?

Will be done later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Host Bluetooth Host (excluding BR/EDR) area: Bluetooth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants