-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Bluetooth: document bt_addr_le_is_resolved() #95011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bluetooth: document bt_addr_le_is_resolved() #95011
Conversation
I believe there is some confusion about what this function does. This function is doing some type-bending, so it's extra important to document it. Signed-off-by: Aleksander Wasaznik <aleksander.wasaznik@nordicsemi.no>
07ab634
to
ad31156
Compare
Would it be better to define an |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive documentation to the bt_addr_le_is_resolved()
function to clarify its purpose and usage constraints. The function performs type inspection on HCI LE event address fields to determine if the Controller resolved a Resolvable Private Address (RPA).
Key Changes
- Added detailed documentation explaining the function's specific purpose for HCI LE event address inspection
- Clarified the critical distinction between HCI event address fields and regular application-layer
bt_addr_le_t
types - Provided comprehensive list of HCI LE events that contain compatible address fields
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Will be done later. |
I believe there is some confusion about what this function does. This function is doing some type-bending, so it's extra important to document it.