samples: ipc: ipc_services: drop unnecessary tests #95007
Conversation
As per its README, the sample's target of choice is nrf5340dk so update Twister file accordingly. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
zephyrbot
requested review from
arnopo,
carlocaione,
doki-nordic,
JarmouniA and
nashif
There was a problem hiding this comment.
All these tests make sense and are quite important to catch regressions and I even expanded them in #94790. It would be in the scope of this PR to find a more suitable place for these test cases
Could you maybe move these targets to tests to make sure this PR does not reduce test coverage? Samples are being run as integration tests.
There was a problem hiding this comment.
Could you maybe move these targets to tests to make sure this PR does not reduce test coverage? Samples are being run as integration tests.
I would really hope that's something someone more familiar with the IPC subsystem and Nordic targets can do.
Samples are being run as integration tests.
They really really should not, please
There was a problem hiding this comment.
I would really hope that's something someone more familiar with the IPC subsystem and Nordic targets can do.
Well, I guess it's safe to say this sample does not contribute to coverage that much, it should probably have enough coverage from the stuff under tests/. Will check on BabbleSim in scope of #94790
They really really should not, please
Ok, thanks for clarification. So samples' tests are supposed to test the sample code and not exercise some extra configs to improve coverage? They should only have configs that are expected to be run by normal users when exploring?
|
As per its README, the sample's target of choice is nrf5340dk so update Twister file accordingly.