samples: video: capture: remove stray USB legacy stack configuration #94227
+0
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The legacy USB device stack configuration used in the board configuration overlay files has been deprecated. It is not causing CI failures because the board lacks a test feature 'video' and is filtered out in CI. Besides the deprecated configuration, the sample code does not enable the USB device stack, so it is not used anyway. Even if it were needed, the correct way to enable logging via USB CDC ACM would be to use the cdc-acm-console snippet. Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
zephyrbot
requested review from
avolmat-st,
kartben,
loicpoulain,
nashif and
ngphibang
|
josuah
approved these changes
Aug 7, 2025
ngphibang
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy USB device stack configuration used in the board configuration overlay files has been deprecated. It is not causing CI failures because the board lacks a test feature 'video' and is filtered out in CI.
Besides the deprecated configuration, the sample code does not enable the USB device stack, so it is not used anyway. Even if it were needed, the correct way to enable logging via USB CDC ACM would be to use the cdc-acm-console snippet.