test_dma_loop: Fix fail with dma_mcux_lpc #94114
Open
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
platform: NXP Drivers
zephyrbot
requested review from
dbaluta,
decsny,
dleach02,
manuargue,
mmahadevan108 and
teburd
Add a num_of_allocated_channels field to struct dma_mcux_lpc_config. Add a a capacity check for dma_X_channel_data_arr in dma_mcux_lpc_configure. Signed-off-by: Vit Stanicek <vit.stanicek@nxp.com>
Release DMA channels allocated through dma_request_channel with dma_release_channel in test_loop, test_loop_suspend_resume and test_loop_repeated_start_stop. This prevents channel allocation leaks and enables the tests to still run even if the utilised DMA driver is configured to only utilise a subset of implemented DMA channels. Signed-off-by: Vit Stanicek <vit.stanicek@nxp.com>
VitekST
force-pushed
the
bugfix/91670-dma-lpc-failed-test
branch
from
bd2eba7 to
fcda1cb
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the
dma_mcux_lpcdriver to include a sanity check when allocating channels. Release channels upon concluding thetest_dma_looptest.Fixes #91670.
The condition was instigated with the DMA driver context being added to the
dma_mcux_lpcdriver (with eeaf860, yes, I acknowledge that I broke this), which enables channels to be requested (allocated). Thetest_dma_looptest requested multiple channels (only a single one was used at a time, but they didn't get released) and as the driver was configured to hold internal state only for a limited number of channels (CONFIG_DMA_MCUX_LPC_NUMBER_OF_CHANNELS_ALLOCATED) without a sanity check when allocating it for each channel, the array holding that state structs was overrun, resulting in memory corruption and system crash.