drivers: adc: nrfx_saadc: Remove platform dependencies #93497
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
platform: nRF
zephyrbot
requested review from
anangl,
bjarki-andreasen,
dbaluta,
decsny,
dleach02,
kl-cruz,
magp-nordic,
manuargue,
masz-nordic,
mmahadevan108 and
nika-nordic
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hal_nordic
DNM (manifest)
bjarki-andreasen
previously approved these changes
Jul 22, 2025
Contributor
bjarki-andreasen
left a comment
bjarki-andreasen
left a comment
There was a problem hiding this comment.
Really nice! been waiting a while for this :)
jaz1-nordic
force-pushed
the
nrfx-7708_pin_translation_to_driver
branch
from
c129ecd to
4c7bc60
Compare
jaz1-nordic
force-pushed
the
nrfx-7708_pin_translation_to_driver
branch
5 times, most recently
from
ba30de0 to
c680885
Compare
jaz1-nordic
force-pushed
the
nrfx-7708_pin_translation_to_driver
branch
from
c680885 to
9239aef
Compare
jaz1-nordic
force-pushed
the
nrfx-7708_pin_translation_to_driver
branch
from
892e8d8 to
760fac2
Compare
zephyrbot
requested review from
KhiemNguyenT,
asmellby,
bjarki-andreasen,
decsny,
erwango,
ioannis-karachalios,
jhedberg,
krish2718,
masz-nordic and
sachinthegreen
Update hal_nordic version to have new common analog functionality. Signed-off-by: Jakub Zymelka <jakub.zymelka@nordicsemi.no>
Remove platform dependencies to make dt-bindings more generic. Signed-off-by: Jakub Zymelka <jakub.zymelka@nordicsemi.no>
Switch saadc pin definitions for generic ones defined in nrf-saadc.h Signed-off-by: Jakub Zymelka <jakub.zymelka@nordicsemi.no>
Make the saadc driver more generic by including a generic header file for analog peripherals and removing platform dependencies. Signed-off-by: Jakub Zymelka <jakub.zymelka@nordicsemi.no>
jaz1-nordic
force-pushed
the
nrfx-7708_pin_translation_to_driver
branch
from
760fac2 to
3c6ad53
Compare
Remove platform dependencies and replace the analog pin mapping method with the generic one from the (LP)COMP driver. Signed-off-by: Jakub Zymelka <jakub.zymelka@nordicsemi.no>
jaz1-nordic
force-pushed
the
nrfx-7708_pin_translation_to_driver
branch
from
3c6ad53 to
472f8ae
Compare
|
decsny
removed request for
adamkondraciuk,
bjarki-andreasen,
decsny,
krish2718,
lstnl and
sachinthegreen
bjarki-andreasen
approved these changes
Oct 14, 2025
Contributor
Author
|
Covered by 99399 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch saadc drivers pin definitions for generic ones defined in nrf-saadc.h