drivers: i2c: Move "Use 10-bit addressing" option to i2c_msg #9334
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9334 +/- ##
=======================================
Coverage 52.28% 52.28%
=======================================
Files 213 213
Lines 25964 25964
Branches 5598 5598
=======================================
Hits 13576 13576
Misses 10150 10150
Partials 2238 2238Continue to review full report at Codecov.
|
drivers/i2c/i2c_nrfx_twi.c
Outdated
There was a problem hiding this comment.
I think this should stay. As long as the flag is available in the API, though it is marked as deprecated, it should be handled correctly to keep the backward compatibility.
Mierunski
force-pushed
the
i2c_10_bit_addr
branch
from
117b210 to
770bc2b
Compare
|
@carlescufi @nashif Could we get this merged? |
This commit adds I2C_MSG_ADDR_10_BITS flag, while keeping I2C_ADDR_10_BITS for backward compatibility. I2C_ADDR_10_BITS flag should be removed as soon as all drivers are modified to use message flag. Signed-off-by: Mieszko Mierunski <mieszko.mierunski@nordicsemi.no>
10 bit addressing is still not supported on nrf chips, but now I2C_MSG_ADDR_10_BITS flag is checked. Signed-off-by: Mieszko Mierunski <mieszko.mierunski@nordicsemi.no>
include/i2c.h
Outdated
There was a problem hiding this comment.
I2C_SLAVE_FLAGS_ADDR_10_BITS references this macro in line 66 (I can't put the comment there). I guess (1 << 0) should be used there directly.
Mierunski
force-pushed
the
i2c_10_bit_addr
branch
from
770bc2b to
af6c270
Compare
|
@MaureenHelm @galak can you take a look at this one? |
galak
left a comment
galak
left a comment
There was a problem hiding this comment.
What about all the other controllers? I wondering if we should say if the controller supports the feature at all, and than handle the error checking there?
8 participants
Fixes #3806
Added new message flag I2C_MSG_ADDR_10_BITS while keeping the old flag for 10 bit addressing for backward compatibility.
Modified nrf i2c driver to check this flag instead, now all other drivers should be modified in the same way.