linker: Re-implement {APP,KERNEL}_INPUT_SECTION #9280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor refactoring and commenting of the _SECTION infrastructure in preparation for future improvements. Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
This rewrites the implementation of the APP_INPUT_SECTION and KERNEL_INPUT_SECTION macros such that an unbounded amount of kernelspace libraries can be used. This resolves zephyrproject-rtos#7703 The new implementation has a caveat/limitation; the linker script developer must invoke APP_INPUT_SECTION before KERNEL_INPUT_SECTION. All in-tree linker scripts happened to already be doing this so no in-tree porting was necessary. Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
Codecov Report
@@ Coverage Diff @@
## master #9280 +/- ##
=======================================
Coverage 52.46% 52.46%
=======================================
Files 201 201
Lines 25290 25290
Branches 5286 5286
=======================================
Hits 13268 13268
Misses 9938 9938
Partials 2084 2084Continue to review full report at Codecov.
|
pizi-nordic
requested review from
pizi-nordic
and removed request for
pizi-nordic
nashif
approved these changes
Aug 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites the implementation of the APP_INPUT_SECTION and
KERNEL_INPUT_SECTION macros such that an unbounded amount of
kernelspace libraries can be used.
This resolves #7703
The new implementation has a caveat/limitation; the linker script
developer must invoke APP_INPUT_SECTION before KERNEL_INPUT_SECTION.
All in-tree linker scripts happened to already be doing this so no
in-tree porting was necessary.