Skip to content

Conversation

@dleach02
Copy link
Member

@dleach02 dleach02 commented Jul 2, 2025

Disable the pwmleds nodes in the dts overlay for rev B/C boards. The FLEXPWM is not routed to LED on these versions.

Fixes #92285

@dleach02 dleach02 added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Jul 2, 2025
status = "disabled";
};

&pwmleds {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it's not required.
Disabling the previous "pwmleds" (line 9) should be sufficient.

Copy link
Contributor

@mmahadevan108 mmahadevan108 Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dleach02 Maybe you can add label to pwmleds node in mimxrt1060_evk.dtsi file and reference the label in these overlay files.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a mistake. I was testing EVKC and forgot to fix the B.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dleach02 Maybe you can add label to pwmleds node in mimxrt1060_evk.dtsi file and reference the label in these overlay files.

I'm not sure it buys us anything to do it as a label. Lets just keep it the same it is.

Disable the pwmleds nodes in the dts overlay for rev B/C boards. The
FLEXPWM is not routed to LED on these versions.

Fixes zephyrproject-rtos#92285

Signed-off-by: David Leach <david.leach@nxp.com>
@dleach02 dleach02 requested a review from butok July 3, 2025 18:31
@Raymond0225 Raymond0225 self-requested a review July 3, 2025 18:38
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 3, 2025

@danieldegrasse danieldegrasse merged commit e3ed029 into zephyrproject-rtos:main Jul 7, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: NXP NXP Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: led: mimxrt1060_evk@C/mimxrt1062/qspi : build failure

7 participants