-
Notifications
You must be signed in to change notification settings - Fork 8.3k
drivers: memc: add driver for stm32 ospi psram #92381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: memc: add driver for stm32 ospi psram #92381
Conversation
752b380 to
3e5e735
Compare
|
Thank you Mario! Could you tag this for backport into v4.1? |
@dkouba-atym I dont think I can or am allowed to. I dont really see any relevance of this driver for v4.1. |
8b0fd92 to
6efb10f
Compare
Only fixes are backported. |
17525a8 to
823d932
Compare
|
I was able to integrate the driver with an STM32U5A9J overlay and successfully write and read an APS6408L-3OBM-BA using the supplied test program. |
@Piziwate As a naive fix, that's unlikely to work correctly, try guarding |
@JarmouniA @erwango should I make it U5xx specific, or should I do the following:
|
|
IMO , we should focus on U5 for now and expansion to a new series should be kept for a future PR. Otherwise we'll lose ourselves in workarounds |
Then the driver config should have |
etienne-lms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there should be 1 commit for the driver part (incl. the DT bindings addition), 1 for board b_u585i_iot02a and a last one to enable test on that board, which may request to add memc tag in the supported list in the board YAML file. Maybe these 2 last commits could be squashed together.
4371901 to
b31dc4f
Compare
301f902 to
0e53c9b
Compare
etienne-lms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some late comments.
| } | ||
|
|
||
| if (clock_control_on(DEVICE_DT_GET(STM32_CLOCK_CONTROL_NODE), | ||
| (clock_control_subsys_t)&dev_cfg->pclken) != 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicking: as mentioned in a few other P-Rs (e.g. #96214 (comment), ), cast to clock_control_subsys_t are not needed (the type is void *).
Not a blocking issue, maybe a tree-wide change will fix all occurrences.
b3c0fe6 to
6ba5617
Compare
dsseng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks
Add a driver for STM32U5 OSPI PSRAM in memory mapped mode. Signed-off-by: Mario Paja <mariopaja@hotmail.com>
Changes enable OSPI PSRAM on b_u585i_iot02a board. Signed-off-by: Mario Paja <mariopaja@hotmail.com>
This change updates buffer size to the full psram size when psram node is available Signed-off-by: Mario Paja <mariopaja@hotmail.com>
Add b_u585i_iot02a board to test/drivers/memc/ram Signed-off-by: Mario Paja <mariopaja@hotmail.com>
6ba5617 to
c4edb9e
Compare
|



Add STM32 OSPI PSRAM driver support in memory mapped mode
Current driver configuration based on
aps6408lon STM32U5xx seriesTest application 1
https://github.com/mariopaja/hello_psram
Custom U575 Board:
b_u585i_iot02a:
Test application 2
tests/drivers/memc/ram