cmake: Improve the error message when the compiler is not executable #9190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the SDK/toolchain has been incorrectly installed such that the user does not have permissions to execute it an incomprehensible errror message occurs. This patch tests that executing 'gcc --version' does not give an error code and errors out with an appropriate error message if it does. This fixes zephyrproject-rtos#8977 Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
Codecov Report
@@ Coverage Diff @@
## master #9190 +/- ##
=======================================
Coverage 52.72% 52.72%
=======================================
Files 201 201
Lines 25277 25277
Branches 5279 5279
=======================================
Hits 13328 13328
Misses 9823 9823
Partials 2126 2126Continue to review full report at Codecov.
|
nashif
approved these changes
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the SDK/toolchain has been incorrectly installed such that the
user does not have permissions to execute it an incomprehensible
errror message occurs.
This patch tests that executing 'gcc --version' does not give an error
code and errors out with an appropriate error message if it does.
This fixes #8977
Signed-off-by: Sebastian Bøe sebastian.boe@nordicsemi.no