kernel: sched: Use ticks as time unit in time slicing. #9137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _update_time_slice_before_swap() function directly compared _time_slice_duration (expressed in ms) with value returned by _get_remaining_program_time() which used ticks as a time unit. Moreover, the _time_slice_duration was also used as an argument for _set_time(), which expects time expressed in ticks. This commit ensures that the same unit (ticks) is used in comparsion and timer adjustments. Signed-off-by: Piotr Zięcik <piotr.ziecik@nordicsemi.no>
pizi-nordic
force-pushed
the
timeslice-fix
branch
from
bc43901 to
751dea7
Compare
Codecov Report
@@ Coverage Diff @@
## master #9137 +/- ##
==========================================
+ Coverage 52.45% 52.45% +<.01%
==========================================
Files 200 200
Lines 25123 25124 +1
Branches 5245 5245
==========================================
+ Hits 13178 13179 +1
Misses 9824 9824
Partials 2121 2121
Continue to review full report at Codecov.
|
The time slicing settings was kept in milliseconds while all related operations was based on ticks. Continuous back and forth conversion between ticks and milliseconds introduced an accumulating error due to rounding in _ms_to_ticks() and __ticks_to_ms(). As result configured time slice duration was not achieved. This commit removes excessive ticks <-> ms conversion by using ticks as time unit for all operations related to time slicing. Also, it fixes #8896 as well as #8897. Signed-off-by: Piotr Zięcik <piotr.ziecik@nordicsemi.no>
pizi-nordic
force-pushed
the
timeslice-fix
branch
from
751dea7 to
37e105d
Compare
andrewboie
approved these changes
Aug 2, 2018
ioannisg
reviewed
Aug 10, 2018
| s32_t _time_slice_elapsed; | ||
| s32_t _time_slice_duration = CONFIG_TIMESLICE_SIZE; | ||
| int _time_slice_prio_ceiling = CONFIG_TIMESLICE_PRIORITY; | ||
| s32_t _time_slice_duration; |
Member
There was a problem hiding this comment.
duration and ceiling are now initialized to 0, right?
Member
There was a problem hiding this comment.
Or, actually, they are initialized by k_sched_time_slice_set in _sched_init, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time slicing settings was kept in milliseconds while all related operations was based on ticks. Continuous back and forth conversion between ticks and milliseconds introduced an accumulating error due to rounding in _ms_to_ticks() and __ticks_to_ms(). As result configured time slice duration was not achieved.
This PR removes excessive ticks <-> ms conversion by using ticks as time unit for all operations related to time slicing.
Also, it fixes #8896, #8897 and #9310