Skip to content

net: sockets: Enable gethostname even if socket-offloading is selected #90849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

net: sockets: Enable gethostname even if socket-offloading is selected #90849

merged 1 commit into from
Jun 3, 2025
+1 −1

Conversation

clamattia
Copy link
Collaborator

Also allow gethostname to be compiled in, even when the socket offloading option is selected.
Fixes: #90843

@clamattia clamattia mentioned this pull request May 30, 2025
Closed
@github-actions github-actions bot requested review from jukkar, pdgendt, rlubos and ssharks May 30, 2025 07:31
jukkar
jukkar reviewed May 30, 2025
View reviewed changes
Copy link
Member

@jukkar jukkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your issue only mentioned gethostname but now you are also enabling getnameinfo for offloaded sockets, perhaps that was not the intention?

@clamattia clamattia force-pushed the host_name_socket_offloading branch from f2633b0 to 23b9f0a Compare May 30, 2025 07:45
@clamattia
Copy link
Collaborator Author

Your issue only mentioned gethostname but now you are also enabling getnameinfo for offloaded sockets, perhaps that was not the intention?

My bad, fixed.

@github-actions github-actions bot added the size: XS A PR changing only a single line of code label May 30, 2025
rlubos
rlubos approved these changes May 30, 2025
View reviewed changes
Copy link
Collaborator

@rlubos rlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the compliance (missing signoff line in the commit message).

@clamattia
net: sockets: Enable gethostname even if socket-offloading is selected
39f7e2a 
Also allow `gethostname` to be compiled in, even when the socket offloading
option is selected.

Signed-off-by: Cla Mattia Galliard <cla-mattia.galliard@zuehlke.com>
@clamattia clamattia force-pushed the host_name_socket_offloading branch from 23b9f0a to 39f7e2a Compare May 30, 2025 07:57
@clamattia
Copy link
Collaborator Author

Please fix the compliance (missing signoff line in the commit message).

done. Sorry.

@clamattia clamattia requested a review from jukkar May 30, 2025 08:22
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kartben kartben merged commit 02d2cc5 into zephyrproject-rtos:main Jun 3, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfriedt cfriedt cfriedt approved these changes

@jukkar jukkar jukkar approved these changes

@rlubos rlubos rlubos approved these changes

@pdgendt pdgendt Awaiting requested review from pdgendt

@ssharks ssharks Awaiting requested review from ssharks

Assignees

@jukkar jukkar

@rlubos rlubos

Labels
area: Networking area: Sockets Networking sockets size: XS A PR changing only a single line of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

net: gethostname: Make available even if offloaded sockets are used
5 participants
@clamattia @cfriedt @jukkar @rlubos @kartben