Remove socketpair in hostap to save memory #90317
Open
+150
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hostap
DNM (manifest)
Add MSG_ZEROCOPY socket flag definition so that it can be used in the code. No real functionality for supporting zerocopy via this flag is provided by this commit. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
Remove Kconfig dependency to socketpair related options as the hostap now uses k_fifo to pass information between different threads. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
jukkar
changed the title
jukkar
force-pushed
the
devel/remove-socketpair-in-hostap
branch
from
37f990d to
15b13be
Compare
github-actions
bot
added
area: Networking
area: POSIX
|
|
See information about memory savings in zephyrproject-rtos/hostap#86 |
|
Needs more testing and review so adding DNM label. |
cfriedt
previously approved these changes
May 24, 2025
Earlier we had socketpair to pass wifi event information from wpa_supplicant side to zephyr adaption layer. This is now replaced by k_fifo to save some RAM. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
Create "wifi mem" command that can show how the heap memory is being used in hostap. The command is available if CONFIG_WIFI_NM_WPA_SUPPLICANT_DEBUG_ALLOC is enabled. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
This is a temporary config to avoid allocation issues until the culprit is found. Some heap usage is not freed properly. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
Make sure to use k_fifo for IPC in hostap to save memory. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
jukkar
force-pushed
the
devel/remove-socketpair-in-hostap
branch
from
636e8df to
ba7a5c8
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace wifi event mechanism by k_fifo. Earlier we had socketpair to pass wifi event information from wpa_supplicant side to zephyr adaption layer. This is now replaced by k_fifo to save some RAM.
This is still WIP and is missing AP mode support.