-
Notifications
You must be signed in to change notification settings - Fork 7.4k
soc: esp32: virtual e-fuses support #90165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
23dce02
to
3d42ffc
Compare
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
3a929dd
to
088d61d
Compare
088d61d
to
4748fab
Compare
b6a26fd
to
ee685e3
Compare
esp32 hal revision update to enable use of virtual efuses Signed-off-by: Marcio Ribeiro <marcio.ribeiro@espressif.com>
Adds support for virtual e-fuses on esp32 socs Signed-off-by: Marcio Ribeiro <marcio.ribeiro@espressif.com>
ee685e3
to
df2cce3
Compare
|
This mode is useful when need to keep changes after reboot | ||
(testing secure_boot and flash_encryption). | ||
|
||
config EFUSE_VIRTUAL_OFFSET |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about ESP32_
prefix?
@@ -164,7 +164,7 @@ manifest: | |||
groups: | |||
- hal | |||
- name: hal_espressif | |||
revision: fa60a7aaa1f834c66413bbaa771794cf8aa82946 | |||
revision: 3400dc972461b46e72691f676f70c7e3548ab3f9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs update or removal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one remark on code organization, otherwise LGTM
@@ -26,6 +27,15 @@ void IRAM_ATTR __esp_platform_app_start(void) | |||
|
|||
esp_flash_config(); | |||
|
|||
#if CONFIG_ESP32_EFUSE_VIRTUAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please hide and unite the efuse init code in soc/common/include/esp_efuse.h
using only a single call? That way, we don't bloat the soc.c
each time we add a new feature.
Adds support for virtual e-fuses on esp32 socs