Skip to content

soc: esp32: virtual e-fuses support #90165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wmrsouza
Copy link
Collaborator

Adds support for virtual e-fuses on esp32 socs

@wmrsouza wmrsouza force-pushed the support/virtual_efuses branch from 23dce02 to 3d42ffc Compare May 19, 2025 14:55
Copy link

github-actions bot commented May 19, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_espressif zephyrproject-rtos/hal_espressif@fa60a7a zephyrproject-rtos/hal_espressif@3400dc9 (zephyr) zephyrproject-rtos/hal_espressif@fa60a7aa..3400dc97

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_espressif DNM (manifest) This PR should not be merged (controlled by action-manifest) labels May 19, 2025
@wmrsouza wmrsouza force-pushed the support/virtual_efuses branch 2 times, most recently from 3a929dd to 088d61d Compare May 22, 2025 08:28
@wmrsouza wmrsouza marked this pull request as ready for review May 22, 2025 08:30
@wmrsouza wmrsouza force-pushed the support/virtual_efuses branch from 088d61d to 4748fab Compare May 22, 2025 08:42
@github-actions github-actions bot added the platform: ESP32 Espressif ESP32 label May 22, 2025
@wmrsouza wmrsouza force-pushed the support/virtual_efuses branch 3 times, most recently from b6a26fd to ee685e3 Compare May 23, 2025 09:02
@github-actions github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label May 23, 2025
wmrsouza added 2 commits May 23, 2025 08:17
esp32 hal revision update to enable use of virtual efuses

Signed-off-by: Marcio Ribeiro <marcio.ribeiro@espressif.com>
Adds support for virtual e-fuses on esp32 socs

Signed-off-by: Marcio Ribeiro <marcio.ribeiro@espressif.com>
@wmrsouza wmrsouza force-pushed the support/virtual_efuses branch from ee685e3 to df2cce3 Compare May 23, 2025 11:20
Copy link

This mode is useful when need to keep changes after reboot
(testing secure_boot and flash_encryption).

config EFUSE_VIRTUAL_OFFSET
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about ESP32_ prefix?

@@ -164,7 +164,7 @@ manifest:
groups:
- hal
- name: hal_espressif
revision: fa60a7aaa1f834c66413bbaa771794cf8aa82946
revision: 3400dc972461b46e72691f676f70c7e3548ab3f9
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs update or removal.

Copy link
Collaborator

@marekmatej marekmatej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one remark on code organization, otherwise LGTM

@@ -26,6 +27,15 @@ void IRAM_ATTR __esp_platform_app_start(void)

esp_flash_config();

#if CONFIG_ESP32_EFUSE_VIRTUAL
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please hide and unite the efuse init code in soc/common/include/esp_efuse.h using only a single call? That way, we don't bloat the soc.c each time we add a new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants