boards: seeed: xiao_esp32c6 external antenna support #90059

mariopaja · 2025-05-16T11:32:59Z

This PR adds The RF switch node and support for the extenal antenna.

msalau · 2025-05-16T12:27:58Z

There are hooks for board initialization:

To make the hooks functional they should be enabled in Kconfig:

config BOARD_XIAO_ESP32C6
+	select BOARD_EARLY_INIT_HOOK
+	select BOARD_LATE_INIT_HOOK

I think these hooks were added for scenarios like yours.

Best regards
Maksim

mariopaja · 2025-05-16T12:52:46Z

@msalau Thank you for the input! I will have a look into it :)

nordicjm · 2025-05-19T09:11:04Z

boards/seeed/xiao_esp32c6/xiao_esp32c6_hpcore_init.c

+	return 0;
+}
+
+SYS_INIT(board_init, POST_KERNEL, CONFIG_KERNEL_INIT_PRIORITY_DEVICE);


use board hook

boards/seeed/xiao_esp32c6/xiao_esp32c6_hpcore.dts

nordicjm · 2025-05-19T09:11:31Z

boards/seeed/xiao_esp32c6/Kconfig

+
+config XIAO_ESP32C6_EXT_ANTENNA
+	bool "XIAO ESP32C6 External Antenna"
+	default n


Suggested change

default n

msalau · 2025-05-19T10:18:57Z

boards/seeed/xiao_esp32c6/xiao_esp32c6_hpcore.dts

@@ -37,6 +37,17 @@
 		watchdog0 = &wdt0;
 	};

+	rf_switch {
+		compatible = "gpio-keys";


AFAIK gpio-keys is meant for inputs not outputs.
I don't know about any generic GPIO output driver, so gpio-leds is the best candidate.
Other boards use it for generic outputs too.
E.g.
heltec_wifi_lora32_v2/heltec_wifi_lora32_v2_procpu.dts
heltec_wifi_lora32_v2/board_init.c

Actually good point, you need to create a custom DTS binding, use of LED for this is not allowed

@nordicjm would dts/bindings/output/gpio-switch.yaml be okay. I guess then this would have to be added in a separate PR

@mariopaja a board can have custom dts bindings.
E.g.:
arduino/opta/dts/bindings/gpio-power-switches.yaml
arduino/opta/arduino_opta-common.dtsi#L35

Thank you :D

boards/seeed/xiao_esp32c6/hpcore_init.c

boards/seeed/xiao_esp32c6/xiao_esp32c6_hpcore.dts

msalau · 2025-05-21T11:05:26Z

@mariopaja One last note :)

Is the feature specific to hpcore?
If yes - we should make this dependency explicit.

E.g.:
boards/seeed/xiao_esp32c6/Kconfig

config XIAO_ESP32C6_EXT_ANTENNA
	bool "XIAO ESP32C6 External Antenna Selector"
+	depends on BOARD_XIAO_ESP32C6_ESP32C6_HPCORE
	select BOARD_LATE_INIT_HOOK
	help
	  Select the external antenna of the XIAO ESP32-C6.
	  By default, the onboard antenna is used.

boards/seeed/xiao_esp32c6/CMakeLists.txt

if(CONFIG_BOARD_XIAO_ESP32C6_ESP32C6_HPCORE)
  zephyr_library()
  zephyr_library_sources(hpcore_init.c)
endif()

mariopaja · 2025-05-21T11:34:10Z

@mariopaja One last note :)

Is the feature specific to hpcore? If yes - we should make this dependency explicit.

E.g.: boards/seeed/xiao_esp32c6/Kconfig
config XIAO_ESP32C6_EXT_ANTENNA
	bool "XIAO ESP32C6 External Antenna Selector"
+	depends on BOARD_XIAO_ESP32C6_ESP32C6_HPCORE
	select BOARD_LATE_INIT_HOOK
	help
	  Select the external antenna of the XIAO ESP32-C6.
	  By default, the onboard antenna is used.
boards/seeed/xiao_esp32c6/CMakeLists.txt
if(CONFIG_BOARD_XIAO_ESP32C6_ESP32C6_HPCORE)
  zephyr_library()
  zephyr_library_sources(hpcore_init.c)
endif()

@msalau I am not sure to tell the truth
@sylvioalves Is wifi enabled only on hpcore on esp32c6 or can it be used also on the lpcore?

sylvioalves · 2025-05-21T12:05:46Z

@msalau I am not sure to tell the truth @sylvioalves Is wifi enabled only on hpcore on esp32c6 or can it be used also on the lpcore?
Wi-Fi is for HPCore only.

sylvioalves · 2025-05-21T12:07:48Z

@mariopaja I think the antenna option (Kconfig and binding) should be SoC specific and not board specific. This Kconfig could be in soc/espressif/common/. That would enable any custom board to have that option available. Would you re-work it?

mariopaja · 2025-05-21T13:25:48Z

@sylvioalves sure, I can do that

Is it okay if I move the Kconfig and dts in a separate commit, or I need to do a separate PR for that?

Is ESP32_EXT_ANTENNA okay as a config?

sylvioalves · 2025-05-21T13:52:01Z

@sylvioalves sure, I can do that

Is it okay if I move the Kconfig and dts in a separate commit, or I need to do a separate PR for that?

Is ESP32_EXT_ANTENNA okay as a config?

ESP32_EXT_ANTENNA sounds good.
Make it all same PR with different commits. Add board's antenna support in the latest to keep bisectability.

mariopaja · 2025-05-26T08:31:05Z

@sylvioalves I started reworking the PR but I dont know where exactly to put the binding.

Should I add it here dts/bindings/net/wireless?

msalau · 2025-05-27T16:29:09Z

dts/bindings/net/wireless/gpio-rf-switch.yaml

+  Group of GPIO-controlled relays used to enable an RF switch and select the active antenna.
+
+compatible: "gpio-rf-switch"
+


The binding looks too generic for me. There is nothing RF or switch specific. This binding can be used to define a GPIO for any purpose.

It seems there nothing RF specific in the switch in general so I'd expect a devicetree entry for an RF switch to be something like this (inspired by zephyr,devmux):

rf_switch: rf-switch { compatible = "gpio-switch"; enable-gpios = <&gpio0 3 GPIO_ACTIVE_LOW>; select-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>; selected = <1>; status = "okay"; };

This way we have pre-defined properties for GPIOs and also can pre-define the selection if needed.

Also adding a generic driver for it doesn't look unreasonable but this widens scope of the PR significantly from a board specific initialization step to a driver for GPIO controllable switches.

@msalau You are right :/

Isnt it then better to be moved to dts/bindings/misc and be renamed into zephyr,gpio-switch.
I wouldnt mind opening another PR specifically for GPIO controllable switches, but I would appreciate to agree upon it :)

Do you accidentally know who is responsible for dts/bindings/misc?

nobody is specifically responsible, because of the nature of them being miscellaneous. But generic bindings of all kind should be reviewed by DT maintainers

This commit add the required dts and Kconfigs to enable external antennas on custom boards Signed-off-by: Mario Paja <mariopaja@hotmail.com>

This PR adds adds The RF switch node and support for the extenal antenna. Signed-off-by: Mario Paja <mariopaja@hotmail.com>

sonarqubecloud · 2025-06-04T08:42:22Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mariopaja force-pushed the xiao_esp32c6_wifi_antenna_switch branch 5 times, most recently from 1826bde to d1744d6 Compare May 16, 2025 12:05

github-actions bot added area: Networking area: Samples Samples area: Wi-Fi Wi-Fi labels May 16, 2025

github-actions bot requested review from jukkar, kartben, krish2718, MaochenWang1, nashif and rlubos May 16, 2025 12:06

github-actions bot assigned jukkar May 16, 2025

mariopaja force-pushed the xiao_esp32c6_wifi_antenna_switch branch 2 times, most recently from 22f751f to 676792e Compare May 16, 2025 12:08

nordicjm requested changes May 19, 2025

View reviewed changes

msalau suggested changes May 19, 2025

View reviewed changes

mariopaja force-pushed the xiao_esp32c6_wifi_antenna_switch branch 8 times, most recently from 7839e88 to ad8031d Compare May 21, 2025 08:57

msalau suggested changes May 21, 2025

View reviewed changes

boards/seeed/xiao_esp32c6/hpcore_init.c Outdated Show resolved Hide resolved

boards/seeed/xiao_esp32c6/xiao_esp32c6_hpcore.dts Outdated Show resolved Hide resolved

mariopaja force-pushed the xiao_esp32c6_wifi_antenna_switch branch from 169a8fd to e6a1373 Compare May 21, 2025 09:41

jukkar added the platform: ESP32 Espressif ESP32 label May 21, 2025

jukkar assigned sylvioalves and unassigned jukkar May 21, 2025

mariopaja force-pushed the xiao_esp32c6_wifi_antenna_switch branch from e6a1373 to 8588e0b Compare May 27, 2025 11:50

github-actions bot added the area: Devicetree label May 27, 2025

github-actions bot requested review from decsny, galak, LucasTambor, marekmatej, rruuaanng and sylvioalves May 27, 2025 11:51

mariopaja force-pushed the xiao_esp32c6_wifi_antenna_switch branch from 8588e0b to ae1a724 Compare May 27, 2025 12:02

msalau reviewed May 27, 2025

View reviewed changes

mariopaja marked this pull request as draft May 27, 2025 17:25

mariopaja mentioned this pull request May 28, 2025

dts: bindings: misc: add generic gpio controlled switch #90712

Closed

soc: espressif: add external antenna support

7235bbd

This commit add the required dts and Kconfigs to enable external antennas on custom boards Signed-off-by: Mario Paja <mariopaja@hotmail.com>

mariopaja force-pushed the xiao_esp32c6_wifi_antenna_switch branch 2 times, most recently from c87554e to 0f77ae3 Compare June 4, 2025 07:58

boards: seeed: xiao_esp32c6 external antenna support

f869dea

This PR adds adds The RF switch node and support for the extenal antenna. Signed-off-by: Mario Paja <mariopaja@hotmail.com>

mariopaja force-pushed the xiao_esp32c6_wifi_antenna_switch branch from 0f77ae3 to f869dea Compare June 4, 2025 08:14

mariopaja marked this pull request as ready for review June 4, 2025 08:31

		Group of GPIO-controlled relays used to enable an RF switch and select the active antenna.

		compatible: "gpio-rf-switch"

boards: seeed: xiao_esp32c6 external antenna support #90059

Are you sure you want to change the base?

boards: seeed: xiao_esp32c6 external antenna support #90059

Conversation

mariopaja commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msalau commented May 16, 2025

Uh oh!

mariopaja commented May 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

msalau May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

msalau commented May 21, 2025

Uh oh!

mariopaja commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sylvioalves commented May 21, 2025

Uh oh!

sylvioalves commented May 21, 2025

Uh oh!

mariopaja commented May 21, 2025

Uh oh!

sylvioalves commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mariopaja commented May 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jun 4, 2025

Quality Gate passed

Uh oh!

Uh oh!

mariopaja commented May 16, 2025 •

edited

Loading

msalau May 19, 2025 •

edited

Loading

mariopaja commented May 21, 2025 •

edited

Loading

sylvioalves commented May 21, 2025 •

edited

Loading