drivers: wifi: siwx91x: Add features to opermode (boot config) #89614
+27
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muahmed-silabs
commented
May 7, 2025
muahmed-silabs
commented
- Added certain features to boot_config
- Added WIFI_SILABS_SIWX91X_LIMIT_PACKET_BUF_PER_STA to Kconfig
- Enabled roaming by default
- Added certain features to boot_config - Added WIFI_SILABS_SIWX91X_LIMIT_PACKET_BUF_PER_STA to Kconfig - Enabled roaming by default Signed-off-by: Muzaffar Ahmed <muzaffar.ahmed@silabs.com>
github-actions
bot
requested review from
asmellby,
jerome-pouiller,
jhedberg,
jukkar,
Kludentwo,
krish2718,
MaochenWang1,
Martinhoff-maker and
rlubos
| help | ||
| In AP mode, if the bit is set, only two packets per Station (STA) | ||
| would be buffered when the STA is in Power Save (PS) mode. | ||
| This helps manage buffer usage and ensures efficient packet handling. |
There was a problem hiding this comment.
The help message should be indented with one tab + 2 spaces.
| SL_SI91X_EXT_FEAT_DISABLE_XTAL_CORRECTION | | ||
| SL_SI91X_EXT_FEAT_NWP_QSPI_80MHZ_CLK_ENABLE | | ||
| SL_SI91X_EXT_FEAT_FRONT_END_SWITCH_PINS_ULP_GPIO_4_5_0 | | ||
| SL_SI91X_EXT_FEAT_FRONT_END_INTERNAL_SWITCH, |
There was a problem hiding this comment.
You can align the values. Either:
.custom_feature_bit_map = SL_SI91X_CUSTOM_FEAT_EXTENSION_VALID |
SL_SI91X_CUSTOM_FEAT_RTC_FROM_HOST,
or:
.custom_feature_bit_map =
SL_SI91X_CUSTOM_FEAT_EXTENSION_VALID |
SL_SI91X_CUSTOM_FEAT_RTC_FROM_HOST,
There was a problem hiding this comment.
One thing that might help some editors to auto-align this, is to put the value inside parentheses, i.e.:
.ext_custom_feature_bit_map = (SL_SI91X_EXT_FEAT_XTAL_CLK |
SL_SI91X_EXT_FEAT_1P8V_SUPPORT |
...
SL_SI91X_EXT_FEAT_FRONT_END_INTERNAL_SWITCH),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.