net:dns-sd: fix handling of mutliple questions per query #89339
+24
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes a bug where multiple questions inside a single DNS-SD query would not be handled correctly. Since dns_msg was used for extracting the question, always the first question in the list would be extracted. The extraction function is changed to use the dotted string format, so it can be called with the already extracted question. Signed-off-by: Toon Stegen <toon@toostsolutions.be>
github-actions
bot
requested review from
jukkar,
pdgendt,
rlubos,
ssharks and
tbursztyka
jukkar
reviewed
May 2, 2025
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a bug in handling multiple questions per DNS-SD query by switching to a dotted string extraction method. Key changes include:
- Removing the dns_msg parameter from send_sd_response and instead using the net_buf result data.
- Updating dns_sd_query_extract to skip a leading dot and to parse labels from a dotted string.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| subsys/net/lib/dns/mdns_responder.c | Removed the dns_msg parameter and adjusted the query extraction call. |
| subsys/net/lib/dns/dns_sd.c | Modified dns_sd_query_extract to use dotted string format and adjust label parsing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where multiple questions inside a single DNS-SD query would not be handled correctly.
Since dns_msg was used for extracting the question, always the first question in the list would be extracted.
The extraction function is changed to use the dotted string format, so it can be called with the already extracted question.