net: mdns increase buf size #89338
Open
net: mdns increase buf size #89338
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
jukkar,
pdgendt,
rlubos,
ssharks and
tbursztyka
jukkar
reviewed
Apr 30, 2025
subsys/net/lib/dns/mdns_responder.c
Outdated
| @@ -115,8 +115,9 @@ static int setup_dst_addr(int sock, sa_family_t family, | |||
| #define DNS_RESOLVER_BUF_CTR (DNS_RESOLVER_MIN_BUF + \ | |||
| CONFIG_MDNS_RESOLVER_ADDITIONAL_BUF_CTR) | |||
|
|
|||
| #define MDNS_RESOLVER_MAX_BUF_SIZE 1024 | |||
There was a problem hiding this comment.
Could you introduce a Kconfig symbol for this, perhaps defaulting the previous default. This way it is easier to adjust the value according to the user needs.
toonst
force-pushed
the
mdns_increase_buf_size
branch
from
d3e166a to
22760fa
Compare
jukkar
reviewed
May 1, 2025
subsys/net/lib/dns/mdns_responder.c
Outdated
| @@ -116,7 +116,7 @@ static int setup_dst_addr(int sock, sa_family_t family, | |||
| CONFIG_MDNS_RESOLVER_ADDITIONAL_BUF_CTR) | |||
|
|
|||
| NET_BUF_POOL_DEFINE(mdns_msg_pool, DNS_RESOLVER_BUF_CTR, | |||
| DNS_RESOLVER_MAX_BUF_SIZE, 0, NULL); | |||
| CONFIG_MDNS_RESOLVER_BUF_SIZE, 0, NULL); | |||
There was a problem hiding this comment.
It is not enough to change this line only because the buffer size is also used in dns_read().
If we only want to use this extra size for mDNS, then we could do something like this:
diff --git a/subsys/net/lib/dns/mdns_responder.c b/subsys/net/lib/dns/mdns_responder.c
index 29f1c657ae1..0ddc08ebb56 100644
--- a/subsys/net/lib/dns/mdns_responder.c
+++ b/subsys/net/lib/dns/mdns_responder.c
@@ -115,8 +115,10 @@ static int setup_dst_addr(int sock, sa_family_t family,
#define DNS_RESOLVER_BUF_CTR (DNS_RESOLVER_MIN_BUF + \
CONFIG_MDNS_RESOLVER_ADDITIONAL_BUF_CTR)
+#define MDNS_RESOLVER_MAX_BUF_SIZE CONFIG_MDNS_RESOLVER_BUF_SIZE
+
NET_BUF_POOL_DEFINE(mdns_msg_pool, DNS_RESOLVER_BUF_CTR,
- DNS_RESOLVER_MAX_BUF_SIZE, 0, NULL);
+ MDNS_RESOLVER_MAX_BUF_SIZE, 0, NULL);
static void create_ipv6_addr(struct sockaddr_in6 *addr)
{
@@ -595,7 +597,7 @@ static int dns_read(int sock,
int queries;
int ret;
- data_len = MIN(len, DNS_RESOLVER_MAX_BUF_SIZE);
+ data_len = MIN(len, MDNS_RESOLVER_MAX_BUF_SIZE);
/* Store the DNS query name into a temporary net_buf, which will be
* eventually used to send a response
22760fa to
21185ae
Compare
rlubos
reviewed
May 14, 2025
subsys/net/lib/dns/mdns_responder.c
Outdated
| NET_BUF_POOL_DEFINE(mdns_msg_pool, DNS_RESOLVER_BUF_CTR, | ||
| DNS_RESOLVER_MAX_BUF_SIZE, 0, NULL); | ||
| MDNS_RESOLVER_BUF_SIZE, 0, NULL); |
There was a problem hiding this comment.
Please stick to the orignal alignment.
for longer DNS-SD text records and instance names we need a bigger buffer Signed-off-by: Toon Stegen <toon@toostsolutions.be>
toonst
force-pushed
the
mdns_increase_buf_size
branch
from
21185ae to
3e0fe5a
Compare
rlubos
approved these changes
May 14, 2025
jukkar
approved these changes
May 14, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for longer DNS-SD text records and instance names we need a bigger buffer