Implement the sbc encoder and decoder based on Android Bluetooth SBC #88865
Conversation
MarkWangChinese
commented
Apr 21, 2025
MarkWangChinese
commented
- It is based on Android Bluetooth SBC.
- The Android Bluetooth SBC is being proposed as an external library in submodule repo (libsbc).
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 added project Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-libsbc
DNM (manifest)
MarkWangChinese
force-pushed
the
feature/impl_sbc_codec
branch
2 times, most recently
from
85f9924 to
4a7d78d
Compare
modules/libsbc/sbc.c
Outdated
| if (encoder == NULL) { | ||
| return -1; | ||
| } |
There was a problem hiding this comment.
Do you really want to return -EPERM here, since EPERM is defined as 1? That's how this would get interpreted by the caller assuming that this function is returning negative posix error codes (like you're doing with -EINVAL and -EOVERFLOW in other places of the function).
There was a problem hiding this comment.
Fixed them all. I changed to use the negative posix error codes, but missed some.
modules/libsbc/sbc.c
Outdated
| encoder_params->s16SamplingFreq = 3; | ||
| break; | ||
| default: | ||
| return -1; |
modules/libsbc/sbc.c
Outdated
| uint32_t ret; | ||
|
|
||
| if ((encoder == NULL) || (in_data == NULL) || (out_data == NULL)) { | ||
| return -1; |
There was a problem hiding this comment.
This function returns uint32_t so it doesn't make sense to try to return a negative value.
modules/libsbc/sbc.c
Outdated
| OI_STATUS status; | ||
|
|
||
| if (decoder == NULL) { | ||
| return -1; |
There was a problem hiding this comment.
Same as -EPERM, i.e. probably not what you want.
Use the Android Bluetooth SBC encoder and decoder. The Android Bluetooth SBC is put as external library (libsbc). sbc.c/sbc.h implement the interface that is compliant with Zephyr style and can be used by Zephyr's other modules ( like A2DP). Signed-off-by: Mark Wang <yichang.wang@nxp.com>
add libsbc to west.yml and add libsbc to MAINTAINERS.yml Signed-off-by: Mark Wang <yichang.wang@nxp.com>
MarkWangChinese
force-pushed
the
feature/impl_sbc_codec
branch
from
4a7d78d to
d79fa33
Compare
