drivers: crc: initial support for renesas,ra-crc driver #87557

thenguyenyf · 2025-03-24T11:15:08Z

This PR is inherited from #74977 to add a CRC device driver with hardware accelerator. We'd like to introduce:

New CRC device drivers: include/zephyr/drivers/crc.h
New CRC subsystem: using the same interface with include/zephyr/sys/crc.h

The crc subsys implementation can be chosen as:

A CRC device driver, get by zephyr,crc alias if it's defined
CRC software-based library, that migrated from old lib/crc to new location: subsys/crc/crc*_sw.c

zephyrbot · 2025-03-24T11:16:06Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

henrikbrixandersen · 2025-03-24T20:34:40Z

@thenguyenyf Nice, thanks! Are you able to give a short presentation of this in an Architecture Working Group meeting?

thenguyenyf · 2025-03-25T04:12:10Z

@thenguyenyf Nice, thanks! Are you able to give a short presentation of this in an Architecture Working Group meeting?

Hello @henrikbrixandersen . I'm willing to join and give a presentation for the new CRC subsystem. How about next week meeting? I may not be able to join this week.

thaoluonguw · 2025-03-28T03:50:24Z

Please rebase to slove conflict.

drivers/crc/crc_renesas_ra.c

thenguyenyf · 2025-04-01T11:44:17Z

Last push just to rebase and solve conflict

Copilot

Pull Request Overview

This PR introduces initial support for the Renesas RA CRC driver by adding hardware-accelerated CRC functionality and updating board configuration files and maintainers accordingly.

Added "crc" as a supported feature in multiple Renesas board YAML files.
Updated the MAINTAINERS file with new CRC subsystem source file paths.

Reviewed Changes

Copilot reviewed 90 out of 100 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
boards/renesas/ek_ra6e2/ek_ra6e2.yaml	Added "crc" to the supported list
boards/renesas/ek_ra4w1/ek_ra4w1.yaml	Added "crc" to the supported list
boards/renesas/ek_ra4m3/ek_ra4m3.yaml	Added "crc" to the supported list
boards/renesas/ek_ra4m2/ek_ra4m2.yaml	Added "crc" to the supported list
boards/renesas/ek_ra4m1/ek_ra4m1.yaml	Added "crc" to the supported list
boards/renesas/ek_ra4l1/ek_ra4l1.yaml	Added "crc" to the supported list
boards/renesas/ek_ra4e2/ek_ra4e2.yaml	Added "crc" to the supported list
boards/renesas/ek_ra2l1/ek_ra2l1.yaml	Added "crc" to the supported list
boards/renesas/ek_ra2a1/ek_ra2a1.yaml	Added "crc" to the supported list
MAINTAINERS.yml	Updated file paths to include new CRC subsystem files

Files not reviewed (10)

boards/renesas/ek_ra2a1/ek_ra2a1.dts: Language not supported
boards/renesas/ek_ra2l1/ek_ra2l1.dts: Language not supported
boards/renesas/ek_ra4e2/ek_ra4e2.dts: Language not supported
boards/renesas/ek_ra4l1/ek_ra4l1.dts: Language not supported
boards/renesas/ek_ra4m1/ek_ra4m1.dts: Language not supported
boards/renesas/ek_ra4m2/ek_ra4m2.dts: Language not supported
boards/renesas/ek_ra4m3/ek_ra4m3.dts: Language not supported
boards/renesas/ek_ra4w1/ek_ra4w1.dts: Language not supported
boards/renesas/ek_ra6e2/ek_ra6e2.dts: Language not supported
boards/renesas/ek_ra6m1/ek_ra6m1.dts: Language not supported

MAINTAINERS.yml

thaoluonguw · 2025-05-28T10:12:42Z

@thenguyenyf : Please solve conflict. Thank you.

soburi · 2025-05-29T10:27:31Z

include/zephyr/drivers/crc.h

@@ -0,0 +1,175 @@
+/*
+ * Copyright (c) 2024 Brill Power Ltd.


Is this copyright notice correct?

I keep this copyright from original contributor due to this interface is inherited from #74977

In that case, it would also be good to add Co-authored-by: to your commit message.
And of course it's a good idea to credit yourself after the original author.

- Implement CRC syscall. - Add CRC driver API. - Introduce support for the CRC driver. Co-authored-by: Zoe Kaute <zoe.kaute@brillpower.com> Signed-off-by: Duy Vo <duy.vo.xc@bp.renesas.com>

Add device tree node for CRC driver on all Renesas MCU Signed-off-by: Duy Vo <duy.vo.xc@bp.renesas.com>

Enable and add CRC node to aliases, chosen for all Renesas MCU Signed-off-by: Duy Vo <duy.vo.xc@bp.renesas.com>

Migrate support from crc library to new crc subsystem Add hardware acclerator backend for crc subsystem Signed-off-by: Duy Vo <duy.vo.xc@bp.renesas.com>

Add samples for CRC driver Signed-off-by: Duy Vo <duy.vo.xc@bp.renesas.com>

Add samples for CRC subsystem Signed-off-by: Duy Vo <duy.vo.xc@bp.renesas.com>

Add ztests for CRC driver Signed-off-by: Duy Vo <duy.vo.xc@bp.renesas.com>

Add ztests for CRC subsystem Signed-off-by: Duy Vo <duy.vo.xc@bp.renesas.com>

Due to the move of lib/crc to subsys/crc, the include path of CRC handler in this test should be updated: - tests/unit/crc Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>

sonarqubecloud · 2025-06-04T02:59:33Z

Quality Gate passed

Issues
157 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

zephyrbot added area: Samples Samples platform: Renesas RA Renesas Electronics Corporation, RA labels Mar 24, 2025

zephyrbot requested review from duynguyenxa, kartben, KhiemNguyenT, nashif, soburi and thaoluonguw March 24, 2025 11:15

zephyrbot assigned kartben Mar 24, 2025

zephyrbot added manifest manifest-hal_renesas DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Mar 24, 2025

thenguyenyf mentioned this pull request Mar 24, 2025

drivers: crc: Add hardware-based CRC driver #74977

Closed

henrikbrixandersen self-requested a review March 24, 2025 20:32

henrikbrixandersen added the Architecture Review Discussion in the Architecture WG required label Mar 24, 2025

github-project-automation bot added this to Architecture Review Mar 24, 2025

github-project-automation bot moved this to Todo in Architecture Review Mar 24, 2025

thenguyenyf force-pushed the renesas_ra_crc_driver_support branch 3 times, most recently from bce01eb to 6b4d778 Compare March 28, 2025 03:30

thenguyenyf force-pushed the renesas_ra_crc_driver_support branch 2 times, most recently from 5e366bc to 6c12cb7 Compare March 31, 2025 06:30

pdgendt reviewed Mar 31, 2025

View reviewed changes

drivers/crc/crc_renesas_ra.c Outdated Show resolved Hide resolved

thenguyenyf force-pushed the renesas_ra_crc_driver_support branch 2 times, most recently from d9db36b to ea016fb Compare April 1, 2025 11:43

thenguyenyf force-pushed the renesas_ra_crc_driver_support branch from 6af150c to 578b46a Compare April 25, 2025 11:39

thenguyenyf requested a review from pdgendt April 25, 2025 11:39

kartben requested a review from Copilot April 25, 2025 18:40

kartben removed their assignment Apr 25, 2025

Copilot AI reviewed Apr 25, 2025

View reviewed changes

thenguyenyf force-pushed the renesas_ra_crc_driver_support branch from 578b46a to 0f47e2f Compare May 5, 2025 02:28

github-actions bot assigned kartben May 5, 2025

github-actions bot removed manifest manifest-hal_renesas DNM (manifest) This PR should not be merged (controlled by action-manifest) labels May 5, 2025

pdgendt reviewed May 5, 2025

View reviewed changes

MAINTAINERS.yml Outdated Show resolved Hide resolved

thenguyenyf force-pushed the renesas_ra_crc_driver_support branch from 0f47e2f to d919d74 Compare May 14, 2025 02:34

pdgendt requested changes May 14, 2025

View reviewed changes

MAINTAINERS.yml Outdated Show resolved Hide resolved

thenguyenyf force-pushed the renesas_ra_crc_driver_support branch from d919d74 to 2ef4b9e Compare May 16, 2025 11:34

thenguyenyf added this to the v4.2.0 milestone May 19, 2025

soburi reviewed May 29, 2025

View reviewed changes

carlescufi removed the Architecture Review Discussion in the Architecture WG required label Jun 2, 2025

thenguyenyf force-pushed the renesas_ra_crc_driver_support branch from 2ef4b9e to 040255e Compare June 4, 2025 02:24

Duy Vo and others added 9 commits June 4, 2025 09:28

drivers: crc: initial support for CRC driver

1b56c3a

- Implement CRC syscall. - Add CRC driver API. - Introduce support for the CRC driver. Co-authored-by: Zoe Kaute <zoe.kaute@brillpower.com> Signed-off-by: Duy Vo <duy.vo.xc@bp.renesas.com>

dts: arm: renesas: add device tree node for CRC driver

485e309

Add device tree node for CRC driver on all Renesas MCU Signed-off-by: Duy Vo <duy.vo.xc@bp.renesas.com>

boards: renesas: add CRC dts node for board support

0c87f25

Enable and add CRC node to aliases, chosen for all Renesas MCU Signed-off-by: Duy Vo <duy.vo.xc@bp.renesas.com>

crc: initial support for CRC subsystem

933dbfa

Migrate support from crc library to new crc subsystem Add hardware acclerator backend for crc subsystem Signed-off-by: Duy Vo <duy.vo.xc@bp.renesas.com>

samples: drivers: crc: add samples for CRC driver

ede8577

Add samples for CRC driver Signed-off-by: Duy Vo <duy.vo.xc@bp.renesas.com>

samples: subsys: crc: add samples for CRC subsystem

3d866d2

Add samples for CRC subsystem Signed-off-by: Duy Vo <duy.vo.xc@bp.renesas.com>

tests: drivers: crc: add ztests for CRC driver

8e928f7

Add ztests for CRC driver Signed-off-by: Duy Vo <duy.vo.xc@bp.renesas.com>

tests: subsys: crc: add ztests for CRC subsystem

e690222

Add ztests for CRC subsystem Signed-off-by: Duy Vo <duy.vo.xc@bp.renesas.com>

tests: crc: update include path for CRC unit test

0ddbc7c

Due to the move of lib/crc to subsys/crc, the include path of CRC handler in this test should be updated: - tests/unit/crc Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>

thenguyenyf force-pushed the renesas_ra_crc_driver_support branch from 040255e to 0ddbc7c Compare June 4, 2025 02:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

drivers: crc: initial support for renesas,ra-crc driver #87557

drivers: crc: initial support for renesas,ra-crc driver #87557

thenguyenyf commented Mar 24, 2025 •

edited

Loading

Uh oh!

zephyrbot commented Mar 24, 2025 •

edited by github-actions bot

Loading

Uh oh!

henrikbrixandersen commented Mar 24, 2025

Uh oh!

thenguyenyf commented Mar 25, 2025

Uh oh!

thaoluonguw commented Mar 28, 2025

Uh oh!

Uh oh!

thenguyenyf commented Apr 1, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

thaoluonguw commented May 28, 2025

Uh oh!

soburi May 29, 2025

Uh oh!

thenguyenyf May 29, 2025

Uh oh!

soburi May 29, 2025 •

edited

Loading

Uh oh!

thenguyenyf Jun 4, 2025

Uh oh!

sonarqubecloud bot commented Jun 4, 2025

Uh oh!

Uh oh!

drivers: crc: initial support for renesas,ra-crc driver #87557

Are you sure you want to change the base?

drivers: crc: initial support for renesas,ra-crc driver #87557

Conversation

thenguyenyf commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zephyrbot commented Mar 24, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

henrikbrixandersen commented Mar 24, 2025

Uh oh!

thenguyenyf commented Mar 25, 2025

Uh oh!

thaoluonguw commented Mar 28, 2025

Uh oh!

Uh oh!

thenguyenyf commented Apr 1, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

thaoluonguw commented May 28, 2025

Uh oh!

soburi May 29, 2025

Choose a reason for hiding this comment

Uh oh!

thenguyenyf May 29, 2025

Choose a reason for hiding this comment

Uh oh!

soburi May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thenguyenyf Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jun 4, 2025

Quality Gate passed

Uh oh!

Uh oh!

thenguyenyf commented Mar 24, 2025 •

edited

Loading

zephyrbot commented Mar 24, 2025 •

edited by github-actions bot

Loading

soburi May 29, 2025 •

edited

Loading